This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Uniques: Reset approved account after transfer #12145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Aug 30, 2022
shawntabrizi
approved these changes
Aug 30, 2022
ggwpez
approved these changes
Aug 30, 2022
bkchr
approved these changes
Aug 30, 2022
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
shawntabrizi
added
B7-runtimenoteworthy
C1-low
KiChjang
reviewed
Aug 30, 2022
redzsina
added
D1-audited 👍
|
bot merge |
|
@Szegoo if you would like a tip, please include your polkadot address in your PR description |
I have added my address, thanks. |
|
/tip small |
|
@kianenigma A small tip was successfully submitted for Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot). https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips |
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* reset approved account * wrap at 100 * doc * fmt * Update frame/uniques/src/tests.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * new test * Update frame/uniques/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * fmt Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
approvedaccount of an item doesn't get reset toNoneafter each transfer. This can cause a problem because it is possible for the owner of the item to approve an item to his other account and after transferring the item he can claim it back.Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA