Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert "Auto-incremental CollectionId" #12059

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 17, 2022

Reverts #11796

The AtLeast32BitUnsigned that we added to the CollectionId breaks XCMv3.
We need to find a better solution on how to do this.

Cumulus companion: paritytech/cumulus#1557

cc @KiChjang @Szegoo @shawntabrizi

@ggwpez ggwpez added A6-revertrevert C1-low PR touches the given topic and has a low impact on builders. labels Aug 17, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 17, 2022
@ggwpez ggwpez added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Aug 17, 2022
@shawntabrizi
Copy link
Member

shawntabrizi commented Aug 17, 2022

is the change this is reverting already deployed to statemint?

if not, we should get this patched on the next release before the change makes it to prod?

@ggwpez
Copy link
Member Author

ggwpez commented Aug 17, 2022

is the change this is reverting already deployed to statemint?

Not sure how to best determine this, but I checked the 0.9.27 statemint runtime from here and it is not in there:

subwasm metadata statemint_runtime-v9270.compact.compressed.wasm --module Uniques

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez changed the title Revert "Auto-incremental CollectionId" [DNM] Revert "Auto-incremental CollectionId" Aug 18, 2022
@ggwpez ggwpez changed the title [DNM] Revert "Auto-incremental CollectionId" Revert "Auto-incremental CollectionId" Aug 19, 2022
@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot paritytech-processbot bot merged commit b7d2cb5 into master Aug 19, 2022
@paritytech-processbot paritytech-processbot bot deleted the revert-11796-autoincrement-collectionId branch August 19, 2022 13:15
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…#12059)

This reverts commit 7d8e5a1.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants