Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[contracts] stabilize seal_code_hash, seal_set_code_hash and seal_own_code_hash #11337

Merged
merged 5 commits into from
May 4, 2022

Conversation

agryaznov
Copy link
Contributor

Since ink_waterfall E2E tests were added for

  • seal_set_code_hash (here)
  • seal_code_hash (here)
  • seal_own_code_hash (here)

hence we can stabilize them with this very PR.

@agryaznov agryaznov added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 2, 2022
@agryaznov agryaznov requested a review from athei as a code owner May 2, 2022 17:36
@athei
Copy link
Member

athei commented May 3, 2022

I think you missed some place according to the CI.

@athei athei requested a review from cmichi May 3, 2022 15:03
@agryaznov agryaznov merged commit 392f0b1 into master May 4, 2022
@agryaznov agryaznov deleted the ag-stabilize branch May 4, 2022 07:35
godcodehunter pushed a commit to sensoriumxr/substrate that referenced this pull request Jun 22, 2022
…l_own_code_hash` (paritytech#11337)

* stabilize seal_code_hash, seal_set_code_hash, seal_own_code_hash

* fix missed place found by CI

* Fixed missed __unstable__

Co-authored-by: Alexander Theißen <alex.theissen@me.com>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
…l_own_code_hash` (paritytech#11337)

* stabilize seal_code_hash, seal_set_code_hash, seal_own_code_hash

* fix missed place found by CI

* Fixed missed __unstable__

Co-authored-by: Alexander Theißen <alex.theissen@me.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…l_own_code_hash` (paritytech#11337)

* stabilize seal_code_hash, seal_set_code_hash, seal_own_code_hash

* fix missed place found by CI

* Fixed missed __unstable__

Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants