This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
SlotDuration: Always fetch the slot duration from the runtime #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slot duration should always be fetched from the runtime instead of being cached in the db. The slot duration is only fetched on startup of the node, so the performance isn't that important. This is especially helpful for the case when the slot duration of a chain should be changed through a runtime upgrade (there be dragons, so take care).
bkchr
added
A0-please_review
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Dec 17, 2021
seunlanlege
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Dec 17, 2021
bkchr
added a commit
to paritytech/cumulus
that referenced
this pull request
Dec 17, 2021
andresilva
approved these changes
Dec 20, 2021
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/cumulus#864 |
|
bot merge |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://github.com/avatars/in/144942?s=60&v=4){kind=small}
paritytech-processbot
bot
deleted the
bkchr-slot-duration-fetch-always
branch
paritytech-processbot bot
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Dec 20, 2021
* Substrate companion for change slot duration fetching paritytech/substrate#10509 * Fix bridges * update lockfile for substrate Co-authored-by: parity-processbot <>
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
Dec 20, 2021
* Substrate companion for fetching slot duration paritytech/substrate#10509 * update lockfile for substrate * Update Co-authored-by: parity-processbot <>
drahnr
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Jan 4, 2022
* Substrate companion for change slot duration fetching paritytech/substrate#10509 * Fix bridges * update lockfile for substrate Co-authored-by: parity-processbot <>
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* Substrate companion for change slot duration fetching paritytech/substrate#10509 * Fix bridges * update lockfile for substrate Co-authored-by: parity-processbot <>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…tech#10509) * SlotDuration: Always fetch the slot duration from the runtime The slot duration should always be fetched from the runtime instead of being cached in the db. The slot duration is only fetched on startup of the node, so the performance isn't that important. This is especially helpful for the case when the slot duration of a chain should be changed through a runtime upgrade (there be dragons, so take care). * Fix docs * Remove logging * Fix warning
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
WebWizrd8
added a commit
to WebWizrd8/cumulus
that referenced
this pull request
Nov 21, 2022
* Substrate companion for fetching slot duration paritytech/substrate#10509 * update lockfile for substrate * Update Co-authored-by: parity-processbot <>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…tech#10509) * SlotDuration: Always fetch the slot duration from the runtime The slot duration should always be fetched from the runtime instead of being cached in the db. The slot duration is only fetched on startup of the node, so the performance isn't that important. This is especially helpful for the case when the slot duration of a chain should be changed through a runtime upgrade (there be dragons, so take care). * Fix docs * Remove logging * Fix warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slot duration should always be fetched from the runtime instead of being cached in the db. The
slot duration is only fetched on startup of the node, so the performance isn't that important. This
is especially helpful for the case when the slot duration of a chain should be changed through a
runtime upgrade (there be dragons, so take care).
polkadot companion: paritytech/polkadot#4556
cumulus companion: paritytech/cumulus#864