Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Emit ContractReverted error when revert flag is set #10481

Merged
merged 4 commits into from
Dec 15, 2021

Conversation

athei
Copy link
Member

@athei athei commented Dec 14, 2021

Fixes #9338

No changes to ink! or UI necessary.

@athei athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Dec 14, 2021
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athei
Copy link
Member Author

athei commented Dec 15, 2021

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit edaf25f into master Dec 15, 2021
@paritytech-processbot paritytech-processbot bot deleted the at-contract-reverted branch December 15, 2021 07:35
seunlanlege pushed a commit to seunlanlege/substrate that referenced this pull request Dec 17, 2021
* Emit `ContractReverted` error when revert flag is set

* `is_success()` -> `did_revert()`
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Emit `ContractReverted` error when revert flag is set

* `is_success()` -> `did_revert()`
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Emit `ContractReverted` error when revert flag is set

* `is_success()` -> `did_revert()`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Return ContractReverted from dispatchables when top level contract reverted
3 participants