This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bounties - reset curator deposit when curator unassigns themself. #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautamdhameja
added
A0-please_review
gautamdhameja
changed the title
shawntabrizi
approved these changes
Dec 7, 2021
|
good catch |
gavofyork
approved these changes
Dec 9, 2021
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
viniul
added
D1-audited 👍
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10442
In the bounties pallet, in the unassign_curator extrinsic, under the arm where the sender is the curator themself, the bounty deposit is not reset to zero.
In other arms, this is being done as part of a utility function is used for slashing the deposit. But in this case, because we don't use this function, we should do this explicitly.
skip check-dependent-cumulus