This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-executor-wasmtime: upgrade wasmtime to 0.30.0 #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes related to memory64 proposal implementation, for additional details see bytecodealliance/wasmtime#3153
slumber
added
A3-in_progress
github-actions
bot
added
A0-please_review
bkchr
approved these changes
Oct 11, 2021
bkchr
reviewed
Oct 12, 2021
| /// | ||
| /// The default is `None`. | ||
| pub max_memory_pages: Option<u32>, | ||
| pub max_memory_size: Option<usize>, |
There was a problem hiding this comment.
Why not continue to use pages here?
There was a problem hiding this comment.
To be aligned with wasmtime interface and avoid intermediate layer of converting it to bytes.
The change in upstream also makes sense, the reasoning (link in the first commit):
The runtime implementation of mmap-based linear memories has changed
to largely work in usize quantities in its API and in bytes instead
of pages. This simplifies various aspects and reflects that
mmap-memories are always bound by usize since that's what the host
is using to address things, and additionally most calculations care
about bytes rather than pages except for the very edge where we're
going to/from wasm.
pepyakin
approved these changes
Oct 12, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9605
Resolves #9606
polkadot companion: paritytech/polkadot#4063