Benchmark or remove hard-coded pallet weights

[ggwpez]

Multiple pallets do not use correct weights, as discovered in paritytech/substrate#13798:

• Sudo Benchmark pallet sudo substrate#13812
• Membership
• Scored pool
• Nicks
• template Use proper weights in the pallet-template substrate#13761 (This is being worked on)

Options are to either benchmark all these pallets or deprecate/decommission them. I am in favour or the latter, if possible.

[iTranscend]

Hi @ggwpez. I'd like to pick up this issue.

Please can you assign it to me?

[ggwpez]

Yes thanks @iTranscend!

I think the sudo pallet will definitely not be deleted.
As for Nicks we can probably delete it. And also not sure about the Membership and scored-pool…

[Doordashcon]

@iTranscend Just seeing that you are assigned to this, already made a push for pallet_sudo🫡

[ggwpez]

Okay @Doordashcon please always report in the issue first to avoid race-conditions like this 😆

@iTranscend the Membership pallet is still used by a lot of para-chains as TechnicalCommitee, so that would also be a good candidate - even if we eventually move it out of the Substrate repo.

[iTranscend]

Haha, race-conditions 😆

That's fine. I'll take up the membership pallet instead.

[Doordashcon]

Noted with thanks @ggwpez