Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clang-14 for paritytech/base-ci-linux #488

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Use clang-14 for paritytech/base-ci-linux #488

merged 1 commit into from
Nov 24, 2022

Conversation

rcny
Copy link
Contributor

@rcny rcny commented Nov 23, 2022

We have linker failures in the Substrate CI most possibly related that clang-13 is too old for currently used Rust versions. This PR bumps clang from 13 to 14 for the base image and the dependent ci-linux image.

@rcny rcny self-assigned this Nov 23, 2022
@rcny rcny requested a review from a team November 23, 2022 19:25
altaua
altaua previously approved these changes Nov 24, 2022
View reviewed changes
@altaua
Copy link
Contributor

altaua commented Nov 24, 2022

Hmm, several ci jobs had just failed due to transient network failures and I approved this pr before they'd all finished running again, but now it turns out several of them are actually legit failing, looks like some downloaded files are getting truncated

@altaua altaua dismissed their stale review November 24, 2022 07:42

ci failing

@altaua
Copy link
Contributor

altaua commented Nov 24, 2022

Oh I see the *_VERSION flags aren't being passed in for some reason.

altaua
altaua approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@altaua altaua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again, aiui now this is going to work when merged, it's just the *-pr jobs that don't set the *_VERSION variables

@alvicsam
Copy link
Contributor

About CI - I added the jobs that work in PR recently, so there might be some bugs

muharem
muharem approved these changes Nov 24, 2022
View reviewed changes
Copy link

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this (:

@muharem muharem mentioned this pull request Nov 24, 2022
Merged
@samelamin samelamin mentioned this pull request Nov 24, 2022
Merged
@alvicsam alvicsam merged commit f35c12a into master Nov 24, 2022
@alvicsam alvicsam deleted the vi-clang-14 branch November 24, 2022 10:39
@muharem
Copy link

muharem commented Nov 24, 2022

@alvicsam nether it does not help, or my jobs running on the prev ci script version
https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2081682

@samelamin
Copy link

Same thing for me

https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2081326

@rcny
Copy link
Contributor Author

rcny commented Nov 24, 2022

We are unable to release the updated images due to the same linker error. Need more time to investigate, clang-14 didn't help.

This was referenced Nov 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muharem muharem muharem approved these changes

@altaua altaua altaua approved these changes

Assignees

@rcny rcny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcny @altaua @alvicsam @muharem @samelamin