This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix migrations #7340
Merged
Fix migrations #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okay this was stupid 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Jun 7, 2023
| @@ -352,13 +361,13 @@ executor_params : Default::default(), | |||
| } | |||
| }; | |||
|
|
|||
| let v4 = V4ActiveConfig::<T>::get() | |||
| let v4 = v4::ActiveConfig::<T>::get() | |||
| .defensive_proof("Could not decode old config") | |||
| .unwrap_or_default(); | |||
There was a problem hiding this comment.
The unwrap_or_default did not help any, since the following V5ActiveConfig::<T>::set ignore it.
ggwpez
added
A0-please_review
liamaharon
approved these changes
Jun 7, 2023
14 tasks
gpestana
approved these changes
Jun 7, 2023
|
bot merge |
chevdor
pushed a commit
that referenced
this pull request
Jun 9, 2023
Okay this was stupid 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Closed
coderobe
pushed a commit
that referenced
this pull request
Jun 12, 2023
Okay this was stupid 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay this was stupid 🤦
To get the CI check green here we will need to decrease the
max_code_sizeto 3 MiB like in #7108. Otherwise the consistency check fails. Maybe it wont go green until paritytech/substrate#14311, not sure.