Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

malus: dont panic on missing validation data #6952

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

ordian
Copy link
Member

@ordian ordian commented Mar 24, 2023

Observed spurious failures when testing #6811.
Sometimes, we get AssumptionCheckOutcome::BadRequest from validation data request, I guess because of pruning

WARN tokio-runtime-worker parachain::runtime-api: cannot query the runtime API version: Api called for an unknown Block: State already discarded

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 24, 2023
@@ -37,6 +37,7 @@ rand = "0.8.5"

[features]
default = []
fast-runtime = ["polkadot-cli/fast-runtime"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure anymore, but it doesn't hurt either 🤣

Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find those errors a bit disturbing. Is the discarded state expected and if so why?

@ordian
Copy link
Member Author

ordian commented Mar 27, 2023

I find those errors a bit disturbing. Is the discarded state expected and if so why?

I encountered this only on my local potato machine running multiple nodes. But also seen this sometimes in the kusama logs Assumption Check: Bad request from time to time. I think this is due to forks and a race with finality/pruning.

* master:
  bump timestamp script to v0.2 (#6954)
  Subsystem channel tweaks (#6905)
  Companion for #13683 (#6944)
@ordian
Copy link
Member Author

ordian commented Apr 26, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 64170f4 into master Apr 26, 2023
@paritytech-processbot paritytech-processbot bot deleted the ao-malus-dont-panic branch April 26, 2023 14:03
ordian added a commit that referenced this pull request Apr 26, 2023
* master:
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
ordian added a commit that referenced this pull request Apr 26, 2023
* master: (39 commits)
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
  update rocksdb to 0.20.1 (#7113)
  Reduce base proof size weight component to zero (#7081)
  PVF: Move PVF workers into separate crate (#7101)
  Companion for #13923 (#7111)
  update safe call filter (#7080)
  PVF: Don't dispute on missing artifact (#7011)
  XCM: Properly set the pricing for the DMP router (#6843)
  pvf: Update docs for PVF artifacts (#6551)
  Bump syn from 2.0.14 to 2.0.15 (#7093)
  Companion for substrate#13771 (#6983)
  Added Dwellir Nigeria bootnodes. (#7097)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants