This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor PVF preparation memory stats #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original purpose of this change was to gate metrics that are unsupported by some systems behind conditional compilation directives (#[cfg]); see #6675 (comment). Then I started doing some random cleanups and simplifications and got a bit carried away. 🙈 The code should be overall tidier than before. Changes: - Don't register unsupported metrics (e.g. `max_rss` on non-Linux systems) - Introduce `PrepareStats` struct as an abstraction over the `Ok` values of `PrepareResult`. It is cleaner, and can be easily modified in the future. - Other small changes
mrcnski
added
I8-refactor
tonyalaribe
approved these changes
Feb 9, 2023
ordian
approved these changes
Feb 9, 2023
sandreim
approved these changes
Feb 9, 2023
| @@ -247,4 +225,26 @@ mod getrusage { | |||
| } | |||
| Ok(result) | |||
| } | |||
|
|
|||
| /// Gets the `ru_maxrss` for the current thread if the OS supports `getrusage`. Otherwise, just | |||
| /// returns `None`. | |||
There was a problem hiding this comment.
This comment seems outdated extract_max_rss_stat returns an option, get_max_rss_thread returns io::Result
koute
approved these changes
Feb 14, 2023
|
bot merge |
paritytech-processbot
bot
deleted the
mrcnski/pvf-memory-stats-refactor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
The original purpose of this change was to gate metrics that are unsupported by some systems, behind conditional compilation directives (#[cfg]); see #6675 (comment).
Then I started doing some random cleanups and simplifications and got a bit carried away. 🙈 The code should be overall tidier than before.
Changes
max_rsson non-Linux systems)PrepareStatsstruct as an abstraction over theOkvalues ofPrepareResult. It is cleaner, and can be easily modified in the future.