Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Added Dwellir bootnodes with non-ssl. #6544

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Added Dwellir bootnodes with non-ssl. #6544

merged 1 commit into from
Feb 6, 2023

Conversation

Maharacha
Copy link
Contributor

@Maharacha Maharacha commented Jan 12, 2023 •
edited
Loading

Since substrate nodes requires ws. Also see #6534
And paritytech/substrate#12024 about the problem.

@Maharacha
Copy link
Contributor Author

@melekes could you be kind to test this? I have tested it with 0.9.36 using -lsub-libp2p=trace and it looks good. But I have not tested with master. Note that our old endpoints are still available but I disabled them temporarily during the test.

melekes
melekes approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tested. all good

@bkchr
Copy link
Member

bkchr commented Jan 12, 2023

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for 6d7ffd0

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. A0-pleasereview labels Jan 12, 2023
@bkchr
Copy link
Member

bkchr commented Jan 12, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: "git" "push" "--porcelain" "dwellir-public" "dwellir-boot-ws", kill_on_drop: false }' failed with status Some(128); output: remote: Permission to dwellir-public/polkadot.git denied to paritytech-processbot[bot].
fatal: unable to access 'https://x-access-token:${SECRET}@github.com/dwellir-public/polkadot.git/': The requested URL returned error: 403

@the-right-joyce the-right-joyce added A0-please_review Pull request needs code review. and removed A0-pleasereview labels Jan 20, 2023
@bkchr
Copy link
Member

bkchr commented Jan 31, 2023

@Maharacha please merge master

@Maharacha
Copy link
Contributor Author

@Maharacha please merge master

I did a rebase!

@melekes
Copy link
Contributor

melekes commented Feb 2, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 382b366

@bkchr bkchr merged commit 2ff97c5 into paritytech:master Feb 6, 2023
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@melekes melekes melekes approved these changes

@bkchr bkchr bkchr approved these changes

@coderobe coderobe coderobe approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Maharacha @bkchr @melekes @coderobe @the-right-joyce