Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

polkadot companion: #13128 (Pools commission) #6264

Merged
merged 56 commits into from
Mar 15, 2023
Merged

polkadot companion: #13128 (Pools commission) #6264

merged 56 commits into from
Mar 15, 2023

Conversation

rossbulat
Copy link

@rossbulat rossbulat commented Nov 10, 2022 •
edited
Loading

This is a companion to introducing nomination pool commission: paritytech/substrate#13128

  • Adds additional weights for new calls
  • Adds migration to the runtimes.
  • Adds InitialGlobalMaxCommission const to pallet_nomination_pools::Config.

@rossbulat rossbulat added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Nov 10, 2022
@paritytech-ci paritytech-ci requested review from a team November 10, 2022 14:58
@rossbulat rossbulat changed the title polkadot companion: https://github.com/paritytech/substrate/pull/12511 polkadot companion: #12511 Nov 10, 2022
@rossbulat rossbulat mentioned this pull request Nov 10, 2022
Closed
@kianenigma kianenigma changed the title polkadot companion: #12511 polkadot companion: #12511 (Pools commission) Dec 5, 2022
@paritytech paritytech deleted a comment from paritytech-cicd-pr Dec 28, 2022
@paritytech paritytech deleted a comment from paritytech-processbot bot Dec 28, 2022
@paritytech-processbot
Copy link

Rebased

@rossbulat
Copy link
Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 184eeba

@rossbulat
Copy link
Author

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@ggwpez ggwpez mentioned this pull request Mar 15, 2023
Merged
@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@ggwpez
Use master lock file
803aa8e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into rb-pools-migrate4
1cf5374
@ggwpez
cargo update -p sp-io
bf8e92e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023

bot clean
bot merge

@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 40ab88b into master Mar 15, 2023
@paritytech-processbot paritytech-processbot bot deleted the rb-pools-migrate4 branch March 15, 2023 14:29
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
05dc083 
* master: (50 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
ordian added a commit that referenced this pull request Mar 21, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
b3b094c 
…slashing-client

* ao-past-session-slashing-runtime: (23 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gpestana gpestana gpestana approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang KiChjang approved these changes

@ordian ordian ordian approved these changes

@jsidorenko jsidorenko jsidorenko approved these changes

@kianenigma kianenigma kianenigma approved these changes

@Ank4n Ank4n Awaiting requested review from Ank4n

@andresilva andresilva Awaiting requested review from andresilva

@gavofyork gavofyork Awaiting requested review from gavofyork

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rossbulat @Ank4n @ggwpez @gpestana @shawntabrizi @KiChjang @ordian @jsidorenko @kianenigma @the-right-joyce