update weights #5507

coderobe · 2022-05-11T15:18:38Z

No description provided.

coderobe · 2022-05-12T07:31:19Z

i tried to use substrate-weight-compare to render a comparison for this but it seems like i can not compile it

coderobe · 2022-05-12T07:41:11Z

this will be backported to the release branch once reviewed & merged

coderobe · 2022-05-12T10:31:20Z

I think some block weights got skipped, or at least it appears so looking at the logs

rel:

2022-05-11 19:11:35 👶 Creating empty BABE epoch changes on what appears to be first startup.    
2022-05-11 19:11:35 Essential task `txpool-background` failed. Shutting down service.    
2022-05-11 19:11:35 CurrentBlockRandomness did not provide entropy    
2022-05-11 19:11:36 Running 10 warmups...    
2022-05-11 19:11:36 CurrentBlockRandomness did not provide entropy    
(removed duplicate lines)
Error: 
   0: Extrinsic is not valid: TransactionValidityError::Invalid(InvalidTransaction::BadProof)
   1: Transaction has a bad signature

chevdor

The weights in this benchmark run remain, as last time, rather stable.
I documented more small changes than usual to help test some tooling.

chevdor · 2022-05-12T08:43:56Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

+		(31_691_000 as Weight)
 			// Standard Error: 2_000
-			.saturating_add((513_000 as Weight).saturating_mul(v as Weight))
-			// Standard Error: 4_000
-			.saturating_add((71_000 as Weight).saturating_mul(t as Weight))
+			.saturating_add((517_000 as Weight).saturating_mul(v as Weight))
+			// Standard Error: 5_000
+			.saturating_add((56_000 as Weight).saturating_mul(t as Weight))
 			.saturating_add(T::DbWeight::get().writes(3 as Weight))


swc-web link

chevdor · 2022-05-12T08:44:19Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

+		(48_969_000 as Weight)
+			// Standard Error: 10_000
+			.saturating_add((1_329_000 as Weight).saturating_mul(a as Weight))
+			// Standard Error: 16_000
+			.saturating_add((285_000 as Weight).saturating_mul(d as Weight))


swc-web link

chevdor · 2022-05-12T08:49:27Z

runtime/kusama/src/weights/pallet_election_provider_multi_phase.rs

+	fn feasibility_check(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
+		(0 as Weight)
+			// Standard Error: 6_000
+			.saturating_add((1_348_000 as Weight).saturating_mul(v as Weight))
+			// Standard Error: 12_000
+			.saturating_add((27_000 as Weight).saturating_mul(t as Weight))
+			// Standard Error: 20_000
+			.saturating_add((9_706_000 as Weight).saturating_mul(a as Weight))
+			// Standard Error: 31_000
+			.saturating_add((1_214_000 as Weight).saturating_mul(d as Weight))
 			.saturating_add(T::DbWeight::get().reads(4 as Weight))


Big decrease down to 0

chevdor · 2022-05-12T09:12:22Z

runtime/kusama/src/weights/pallet_scheduler.rs

 	fn on_initialize_named_resolved(s: u32, ) -> Weight {
-		(452_000 as Weight)
+		(0 as Weight)
 			// Standard Error: 29_000
-			.saturating_add((19_512_000 as Weight).saturating_mul(s as Weight))
+			.saturating_add((20_816_000 as Weight).saturating_mul(s as Weight))
 			.saturating_add(T::DbWeight::get().reads(1 as Weight))
 			.saturating_add(T::DbWeight::get().reads((2 as Weight).saturating_mul(s as Weight)))
 			.saturating_add(T::DbWeight::get().writes(1 as Weight))


in situations like this, the constant factor is 2 orders of magnitude smaller than the linear factor. So even s = 1 will make this change hardly noticeable.

This is just the result of linear fitting from my view.

chevdor · 2022-05-12T09:12:33Z

runtime/kusama/src/weights/pallet_scheduler.rs

 	fn on_initialize_periodic_resolved(s: u32, ) -> Weight {
-		(0 as Weight)
-			// Standard Error: 30_000
-			.saturating_add((21_846_000 as Weight).saturating_mul(s as Weight))
+		(315_000 as Weight)
+			// Standard Error: 33_000
+			.saturating_add((23_338_000 as Weight).saturating_mul(s as Weight))
 			.saturating_add(T::DbWeight::get().reads(1 as Weight))
 			.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(s as Weight)))
 			.saturating_add(T::DbWeight::get().writes(1 as Weight))


Bumped from 0

chevdor · 2022-05-12T09:13:11Z

runtime/kusama/src/weights/pallet_scheduler.rs

 	fn on_initialize_resolved(s: u32, ) -> Weight {
-		(3_196_000 as Weight)
-			// Standard Error: 25_000
-			.saturating_add((18_358_000 as Weight).saturating_mul(s as Weight))
+		(94_000 as Weight)
+			// Standard Error: 31_000
+			.saturating_add((19_898_000 as Weight).saturating_mul(s as Weight))
 			.saturating_add(T::DbWeight::get().reads(1 as Weight))
 			.saturating_add(T::DbWeight::get().reads((2 as Weight).saturating_mul(s as Weight)))
 			.saturating_add(T::DbWeight::get().writes(1 as Weight))


Significant reduction

chevdor · 2022-05-12T09:24:49Z

runtime/kusama/src/weights/pallet_treasury.rs

 	fn remove_approval() -> Weight {
-		(7_600_000 as Weight)
+		(3_187_000 as Weight)
 			.saturating_add(T::DbWeight::get().reads(1 as Weight))
 			.saturating_add(T::DbWeight::get().writes(1 as Weight))
 	}


chevdor · 2022-05-12T09:45:00Z

runtime/kusama/src/weights/runtime_parachains_ump.rs

 	fn service_overweight() -> Weight {
-		(18_399_000 as Weight)
+		(25_646_000 as Weight)
 			.saturating_add(T::DbWeight::get().reads(1 as Weight))
 			.saturating_add(T::DbWeight::get().writes(1 as Weight))
 	}


chevdor · 2022-05-12T10:18:24Z

runtime/polkadot/src/weights/pallet_scheduler.rs

+		(3_124_000 as Weight)
+			// Standard Error: 25_000
+			.saturating_add((18_227_000 as Weight).saturating_mul(s as Weight))


chevdor · 2022-05-12T10:19:56Z

runtime/polkadot/src/weights/pallet_utility.rs

 pub struct WeightInfo<T>(PhantomData<T>);
 impl<T: frame_system::Config> pallet_utility::WeightInfo for WeightInfo<T> {
 	fn batch(c: u32, ) -> Weight {
-		(10_504_000 as Weight)
+		(4_943_000 as Weight)
 			// Standard Error: 2_000
-			.saturating_add((4_057_000 as Weight).saturating_mul(c as Weight))
+			.saturating_add((3_798_000 as Weight).saturating_mul(c as Weight))
 	}


EgorPopelyaev · 2022-05-12T10:41:02Z

runtime/polkadot/src/weights/pallet_utility.rs

 	}
 	fn force_batch(c: u32, ) -> Weight {
-		(12_678_000 as Weight)
+		(532_000 as Weight)
 			// Standard Error: 2_000


The weight significantly went down

coderobe · 2022-05-12T10:44:13Z

bot merge

* rococo: update weights * polkadot: update weights * kusama: update weights * westend: update weights

shawntabrizi · 2022-05-13T17:42:06Z

@chevdor @coderobe @ggwpez @crystalin

The ecosystem teams have asked us to mark weight updates as Runtime Noteworthy, since for some of them, it may affect their fee logic.

I know this happens for every release, but I think it should not be such a big deal to add the tag.

I have updated the tag here :)

chevdor · 2022-05-13T21:05:03Z

Please note that we are reporting in this release many more than we usually do. The reason is that @ggwpez is working on a tool to help spotting changes and having a few noticeable changes helps with the debugging.

Most of the "changes" reported in this PR are much smaller than what we usually report, for the reason mentioned above. I don't think this should be more note worthy than other releases. As a matter of fact, the weights in this PR are very close to the previous and this is, with the previous release, probably one of the least significant release in terms of weight changes.

I totally don't mind the label but it would then show up for each release because we do update the weigths (so far) for evey release. The introduction of changes such as paritytech/polkadot-sdk#826 however could help remove the noise and better focus on the real significant changes.

chevdor · 2022-05-13T21:08:49Z

FYI: As it stands now, it is unlikely that we rebuild a new RC before the final (= the current release and release notes look good :)).

That means the new tag would not be picked up as we probably won't generate a new release notes.

I added however the task in #5496 to add the mention manually so it shows up.

rococo: update weights

a9e8431

coderobe added 3 commits May 12, 2022 09:24

polkadot: update weights

ed32654

kusama: update weights

d6014ae

westend: update weights

12486e7

coderobe marked this pull request as ready for review May 12, 2022 07:31

coderobe requested review from chevdor and EgorPopelyaev May 12, 2022 07:31

github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels May 12, 2022

coderobe mentioned this pull request May 12, 2022

Polkadot v0.9.22 Release checklist #5496

Closed

22 tasks

chevdor approved these changes May 12, 2022

View reviewed changes

EgorPopelyaev approved these changes May 12, 2022

View reviewed changes

EgorPopelyaev reviewed May 12, 2022

View reviewed changes

paritytech-processbot bot merged commit b677046 into master May 12, 2022

paritytech-processbot bot deleted the coderobe/weights-22-m branch May 12, 2022 10:44

coderobe added a commit that referenced this pull request May 12, 2022

update weights (#5507)

3d206e1

* rococo: update weights * polkadot: update weights * kusama: update weights * westend: update weights

coderobe mentioned this pull request May 12, 2022

update weights (#5507) #5511

Merged

coderobe added a commit that referenced this pull request May 12, 2022

update weights (#5507) (#5511)

b052bd9

* rococo: update weights * polkadot: update weights * kusama: update weights * westend: update weights

shawntabrizi added B7-runtimenoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels May 13, 2022

github-actions bot mentioned this pull request Jun 22, 2022

Update substrate/polkadot/cumulus from v0.9.20 to v0.9.23 moonbeam-foundation/moonbeam#1623

Closed

This was referenced Jul 18, 2022

Update polkadot/moonbeam/orml from v0.9.20 to v0.9.23 imstar15/OAK-blockchain#6

Closed

Update polkadot/moonbeam/orml from v0.9.20 to v0.9.23 imstar15/OAK-blockchain#7

Open

ghbot-test bot mentioned this pull request Jul 28, 2022

Dependencies update imstar15/OAK-blockchain#25

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update weights #5507

update weights #5507

coderobe commented May 11, 2022

coderobe commented May 12, 2022

coderobe commented May 12, 2022

coderobe commented May 12, 2022

chevdor left a comment

chevdor May 12, 2022

ggwpez May 13, 2022

chevdor May 12, 2022

ggwpez May 13, 2022

chevdor May 12, 2022

chevdor May 12, 2022

shawntabrizi May 13, 2022

chevdor May 12, 2022

chevdor May 12, 2022

chevdor May 12, 2022

chevdor May 12, 2022

chevdor May 12, 2022

chevdor May 12, 2022

EgorPopelyaev May 12, 2022

coderobe commented May 12, 2022

shawntabrizi commented May 13, 2022 •

edited

Loading

chevdor commented May 13, 2022

chevdor commented May 13, 2022

update weights #5507

update weights #5507

Conversation

coderobe commented May 11, 2022

coderobe commented May 12, 2022

coderobe commented May 12, 2022

coderobe commented May 12, 2022

chevdor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderobe commented May 12, 2022

shawntabrizi commented May 13, 2022 • edited Loading

chevdor commented May 13, 2022

chevdor commented May 13, 2022

shawntabrizi commented May 13, 2022 •

edited

Loading