Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Use proper bounded vector type for nominations #10601 #4709

Merged
merged 7 commits into from
Jan 25, 2022
Merged

Companion for Use proper bounded vector type for nominations #10601 #4709

merged 7 commits into from
Jan 25, 2022

Conversation

georgesdib
Copy link
Contributor

Companion to paritytech/substrate#10601

Renaming MAX_NOMINATIONS to MaxNominations and changing type after changes in substrate in the accompanying PR.

@kianenigma

Fixing polkadot after subtrate changes
5e29540 
`MAX_NOMINATIONS` was changed to `MaxNominations`
@georgesdib georgesdib mentioned this pull request Jan 12, 2022
Merged
@kianenigma
Copy link
Contributor

@georgesdib can you update master here?

@kianenigma
Copy link
Contributor

hmm strange companion build failure here.

@georgesdib
Copy link
Contributor Author

hmm strange companion build failure here.

Was the build retriggered after my merge for the substrate PR?

@paritytech-processbot
Copy link

Waiting for commit status.

@georgesdib
Copy link
Contributor Author

georgesdib commented Jan 25, 2022 •
edited
Loading

The status is a bit weird, what does that mean? Is it stuck checking if the substrate PR merged well? (That PR seems to be in a weird state as well, having successfully merged but then returning a merge error)

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for 160adf7

@bkchr
Copy link
Member

bkchr commented Jan 25, 2022

The status is a bit weird, what does that mean? Is it stuck checking if the substrate PR merged well? (That PR seems to be in a weird state as well, having successfully merged but then returning a merge error)

It required to approve running the jobs, because this was the first time you created a pr.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jan 25, 2022
@bkchr bkchr merged commit 728070d into paritytech:master Jan 25, 2022
@georgesdib georgesdib deleted the bound-nomination branch January 25, 2022 19:39
ordian added a commit that referenced this pull request Jan 27, 2022
@ordian
Merge branch 'master' into refactor_check_validation_outputs
675dde3 
* master:
  Fix incomplete sorting. (#4795)
  Companion for better way to resolve `Phase::Emergency` via governance #10663 (#4757)
  Refactor and fix usage of `get_session_index()` and `get_session_info_by_index()` (#4735)
  `relay chain selection` and `dispute-coordinator` fixes and improvements (#4752)
  Fix tests (#4787)
  log concluded disputes (#4785)
  availability-distribution: look for leaf ancestors within the same session (#4596)
  Companion for Use proper bounded vector type for nominations #10601 (#4709)
  Fix release profile (#4778)
  [ci] remove publish-s3-release (#4779)
  Companion for substrate#10632 (#4689)
  [ci] pipeline chores (#4775)
  New changelog scripts (#4491)
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@georgesdib @kianenigma
@shawntabrizi @Wizdave97
Companion for Use proper bounded vector type for nominations #10601 (p…
a714c37 
…aritytech#4709)

* Fixing polkadot after subtrate changes
`MAX_NOMINATIONS` was changed to `MaxNominations`

* Fixing some more places

* Apply suggestions from code review

* update lockfile for {"substrate"}

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

@emostov emostov Awaiting requested review from emostov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgesdib @kianenigma @bkchr @shawntabrizi