Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

paras: add log target #4478

Merged
merged 1 commit into from
Dec 16, 2021
Merged

paras: add log target #4478

merged 1 commit into from
Dec 16, 2021

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Dec 7, 2021 •
edited
Loading

Simply extract hardcoded log target into a const.

skip check-dependent-cumulus

@pepyakin
Copy link
Contributor Author

pepyakin commented Dec 7, 2021 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Dec 7, 2021
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 7, 2021
@pepyakin pepyakin added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 7, 2021
@pepyakin pepyakin force-pushed the pep-pvf-paras branch 2 times, most recently from d691fb6 to 13ed75f Compare December 8, 2021 14:51
@pepyakin pepyakin force-pushed the pep-pvf-paras branch 3 times, most recently from 9ffffac to 7061875 Compare December 14, 2021 11:14
drahnr
drahnr approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing that there is one additional commit in here, the log tag refactor lgtm.

@pepyakin
Copy link
Contributor Author

yeah, that's because this PR/diff depends on the pep-pvf-paras. I did not update it so to avoid the endless:
Screenshot 2021-12-16 at 13 04 27

@pepyakin pepyakin force-pushed the pep-pvf-paras branch 2 times, most recently from e678f65 to 48591fd Compare December 16, 2021 15:21
Base automatically changed from pep-pvf-paras to master December 16, 2021 16:14
@pepyakin
paras: add log target
d6954a2 
Simply extract hardcoded log target into a const.
@drahnr
Copy link
Contributor

drahnr commented Dec 16, 2021

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 2004217 into master Dec 16, 2021
@paritytech-processbot paritytech-processbot bot deleted the pep-paras-log-target branch December 16, 2021 17:00
@pepyakin pepyakin mentioned this pull request Dec 16, 2021
Merged
drahnr pushed a commit that referenced this pull request Dec 16, 2021
@pepyakin @drahnr
paras: add log target (#4478)
e4a6b16 
Simply extract hardcoded log target into a const.
ordian added a commit that referenced this pull request Dec 16, 2021
@ordian
Merge branch 'master' into ao-session-info-3227
31b9388 
* master:
  Fix fmt on master (#4546)
  Support new version of zombienet (#4528)
  naming consistency (#4539)
  paras: add log target (#4478)
ordian added a commit that referenced this pull request Dec 16, 2021
@ordian
Merge branch 'master' into ao-session-info-migration
dacda5a 
* master:
  Fix fmt on master (#4546)
  Support new version of zombienet (#4528)
  naming consistency (#4539)
  paras: add log target (#4478)
drahnr pushed a commit that referenced this pull request Jan 4, 2022
@pepyakin @drahnr
paras: add log target (#4478)
e65ccd2 
Simply extract hardcoded log target into a const.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepyakin @drahnr @bkchr