This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add Encointer as TrustedTeleporter to Kusama #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joepetrowski May I request your review? It's copy-paste from our previous PR #4213 for testnets |
joepetrowski
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Looks OK to me. Question is whether we:
- Merge now and put it in the runtime before Encointer would onboard. If the referendum to add Encointer as a common good chain failed, we could remove it from the runtime later.
- Only merge after Encointer gets accepted by Kusama referendum as a common good chain.
Will let others chime in on the two options.
joepetrowski
added
A0-please_review
|
not sure what that CI error is about. Seems unrelated to this PR |
|
I would suggest to wait until the chain is registered in order to merge this. The team has requested for the common good slot motion to kick off from lease period 18. |
|
Now that Encointer has been ratified to become a common good parachain on Kusama, can we merge this for the next runtime upgrade? |
KiChjang
approved these changes
Dec 11, 2021
ordian
added a commit
that referenced
this pull request
Dec 16, 2021
* master: Bump tokio from 1.14.0 to 1.15.0 (#4537) Bump mick-jaeger from 0.1.6 to 0.1.7 (#4538) Versi chainspec based on Rococo. (#4485) Bump proc-macro2 from 1.0.33 to 1.0.34 (#4526) fix compile with new compiler - dead code (#4530) introduce trusted parachain Encointer for rococo and westend (#4213) add Encointer TrustedTeleporter (#4401) Bump libc from 0.2.109 to 0.2.112 (#4522) Bump serde_json from 1.0.72 to 1.0.73 (#4523)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares for the case where Encointer's proposal to be onboarded as a common good parachain will pass.