Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

implement dispatch_as #4075

Merged
merged 5 commits into from
Nov 4, 2021
Merged

implement dispatch_as #4075

merged 5 commits into from
Nov 4, 2021

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Oct 14, 2021

Companion for paritytech/substrate#9934

cumulus companion: paritytech/cumulus#715

@KiChjang KiChjang added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Nov 4, 2021
@KiChjang
Copy link
Contributor

KiChjang commented Nov 4, 2021

Crud, this requires an update to cumulus as well it seems:

  error[E0046]: not all trait items implemented, missing: `PalletsOrigin`
     --> /builds/parity/polkadot/cumulus/polkadot-parachains/statemine/src/lib.rs:302:1
      |
  302 | impl pallet_utility::Config for Runtime {
      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `PalletsOrigin` in implementation
      |
      = help: implement the missing item: `type PalletsOrigin = Type;`
  error[E0046]: not all trait items implemented, missing: `dispatch_as`
    --> /builds/parity/polkadot/cumulus/polkadot-parachains/statemine/src/weights/pallet_utility.rs:28:1
     |
  28 | impl<T: frame_system::Config> pallet_utility::WeightInfo for WeightInfo<T> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `dispatch_as` in implementation
     |
     = help: implement the missing item: `fn dispatch_as() -> u64 { todo!() }`
  For more information about this error, try `rustc --explain E0046`.
  error: could not compile `statemine-runtime` due to 2 previous errors

@KiChjang
Copy link
Contributor

KiChjang commented Nov 4, 2021

Ah, found it: paritytech/cumulus#715

@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@shawntabrizi shawntabrizi merged commit 7a53298 into paritytech:master Nov 4, 2021
@xlc xlc deleted the dispatch-as branch November 5, 2021 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants