Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Dispatchable XCMs should translate to v0 #4062

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Conversation

gavofyork
Copy link
Member

Previously, XCMs sendable from the XCM pallet could not be translated to v1/v0. This makes a quick fix.

It also switches the WrapVersion impl for Kusama/Rococo to XCM pallet, allowing for v2 -> v2 messages on destinations that support it.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 12, 2021
@gavofyork gavofyork added B7-runtimenoteworthy D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Oct 12, 2021
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weighing the remote message by the intermediate chain is not ideal, as the weigher may fail to weigh it for whatever reason, but that will have to do now in order to get a somewhat sensible weight.

Comment on lines +530 to +531
BuyExecution { fees, weight_limit: Limited(0) },
DepositAsset { assets: Wild(All), max_assets, beneficiary },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should put this in the README for XCMv2, highlighting that it's very important for Weigher implementations to give proper weights for BuyExecution and DepositAsset.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - as long as chains are on v1/v0, they must use the same (or lower) weights as Kusama.

@gavofyork gavofyork merged commit 53cd9a6 into master Oct 12, 2021
@gavofyork gavofyork deleted the gav-fix-for-xcm-v0 branch October 12, 2021 13:35
@gavofyork gavofyork added this to the v0.9.12 milestone Oct 12, 2021
ordian added a commit that referenced this pull request Oct 14, 2021
* master: (40 commits)
  use pipeline-scripts for dependent projects script (#4017)
  companion for substrate/10013 (#4078)
  fix restart issue of staking miner (#4073)
  use `WEIGHT_PER_SECOND` (#4077)
  Switch to compressed runtimes (#4061)
  Create a README for XCMv1 detailing notable changes (#4058)
  Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
  Move runtime to with_transaction in order to Rollback state changes (#4067)
  Update wasmtime config to match new version in substrate (#4063)
  Fix XCM Weights on Westend (#4066)
  Dispatchable XCMs should translate to v0 (#4062)
  Add xcm fuzzer (#3869)
  Bump trybuild from 1.0.49 to 1.0.50 (#4060)
  Companion PR for ss58 crate (#3953)
  overseer: simplify debugging some more (#4053)
  Bump thiserror from 1.0.29 to 1.0.30 (#4048)
  Bump strum from 0.21.0 to 0.22.0 (#4047)
  Add para pallets to polkadot benchmarks (#4045)
  Fixes broken docker link in docker descriptiob (#4043)
  Bump trybuild from 1.0.48 to 1.0.49 (#4039)
  ...
emostov pushed a commit that referenced this pull request Nov 1, 2021
* Dispatchable XCMs should translate to v0

* Formatting

* Update Westend's XCM WrapVersion
@chevdor chevdor added the T6-XCM This PR/Issue is related to XCM. label Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants