Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHW for building and publishing docker images #1391

Merged
merged 29 commits into from
Sep 6, 2023

Conversation

EgorPopelyaev
Copy link
Contributor

This PR introduces new combined GitHub Workflow to build and publish docker images for polkadot, staking-minerand polkadot-parachain.

For now, PR has only a manual trigger, which can be used to start the process.
It has a possibility to build and push images for release candidates (that was requested by the DevOps team) and for the final release version for all three projects.

Closes #1278

@EgorPopelyaev EgorPopelyaev added the R0-silent Changes should not be mentioned in any release notes label Sep 4, 2023
@EgorPopelyaev EgorPopelyaev requested review from alvicsam and a team September 4, 2023 14:45
@paritytech-ci paritytech-ci requested a review from a team September 4, 2023 14:47
@EgorPopelyaev EgorPopelyaev changed the title Ep docker ghw GHW for building and publishing docker images Sep 4, 2023
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing our lib (for Github) under the .gitlab folder is not a good idea.

.gitlab/common/lib.sh Show resolved Hide resolved
.github/workflows/release-50_publish-docker.yml Outdated Show resolved Hide resolved
.github/workflows/release-50_publish-docker.yml Outdated Show resolved Hide resolved
@EgorPopelyaev
Copy link
Contributor Author

bot rebase

@command-bot
Copy link

command-bot bot commented Sep 5, 2023

@EgorPopelyaev Unknown command "rebase". Refer to help docs and/or source code.

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM.

@@ -0,0 +1,48 @@
FROM docker.io/parity/base-bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mix of Dockfiles here and under scripts/polkadot/....
Could we not have all Dockerfiles together ? That would avoid having this folder here with only 2 Dockerfiles.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) September 6, 2023 12:04
@EgorPopelyaev EgorPopelyaev merged commit eeb368e into paritytech:master Sep 6, 2023
103 of 106 checks passed
ordian added a commit that referenced this pull request Sep 6, 2023
* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...
ordian added a commit that referenced this pull request Sep 7, 2023
* master: (28 commits)
  Adds base benchmark for do_tick in broker pallet (#1235)
  zombienet: use another collator image for the slashing test (#1386)
  Prevent a fail prdoc check to block (#1433)
  Fix nothing scheduled on session boundary (#1403)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  ...
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
* add ghw and scripts for docker image deployment

* debug

* add permissions for content

* fix path to the bin folder

* add tags

* rename env

* fix path to docker file

* make polkadot-parachain executable

* fix typo

* fix more typos

* test

* revert back  use of  working directory

* mke bin executable in the artifacts folder

* use cd instead of working directory

* change path to cash

* fix path to cash

* change cache key

* delete old flows

* addressed PR comments

* fix path

* reorg docker files
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* add ghw and scripts for docker image deployment

* debug

* add permissions for content

* fix path to the bin folder

* add tags

* rename env

* fix path to docker file

* make polkadot-parachain executable

* fix typo

* fix more typos

* test

* revert back  use of  working directory

* mke bin executable in the artifacts folder

* use cd instead of working directory

* change path to cash

* fix path to cash

* change cache key

* delete old flows

* addressed PR comments

* fix path

* reorg docker files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHW: Publish containers
4 participants