Symlink chain-specs json files to crate where they are used #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morganamilo
added
the
A1-insubstantial
Morganamilo
force-pushed
the
morganamilo/symlink
branch
from
14719be
to
15e80f8
Compare
When publishing crates, each crate becomes it's own tarball that can't access files from other crates. So symlink the files to be crate local and cargo will replace the symlinks with real files at publish time. We can't just move all of them as it makes the package larger than the max crates.io package size.
Morganamilo
force-pushed
the
morganamilo/symlink
branch
from
15e80f8
to
b71d98e
Compare
Morganamilo
added
T9-cumulus
Morganamilo
requested review from
PierreBesson,
bkchr,
bkontur and
joepetrowski
bkchr
approved these changes
Aug 30, 2023
lexnv
approved these changes
Aug 30, 2023
michalkucharczyk
approved these changes
Aug 30, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
When publishing crates, each crate becomes it's own tarball that can't access files from other crates. So symlink the files to be crate local and cargo will replace the symlinks with real files at publish time. We can't just move all of them as it makes the package larger than the max crates.io package size. Co-authored-by: Javier Viola <javier@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing crates, each crate becomes it's own tarball that can't access files from other crates. So symlink the files to be crate local and cargo will replace the symlinks with real files at publish time.
We can't just move all of them as it makes the package larger than the max crates.io package size.