Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved transaction payment pallet #273

Open
xlc opened this issue Jun 9, 2022 · 1 comment
Open

Improved transaction payment pallet #273

xlc opened this issue Jun 9, 2022 · 1 comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@xlc
Copy link
Contributor

xlc commented Jun 9, 2022

Currently transaction payment pallet made a lot of assumption of how the fee is calculated and charged and made it not suitable for many chains.

The asset tx payment pallet is also not generic enough to be reusable.

Parachain teams are making their own fork to support fee payments with different tokens. It will be good if we can have a generic transaction payment pallet to abstract common code to avoid duplicated code and at same time to be generic enough so that parachain teams can extend the pallet, instead of forking it.

Examples from parachains:

Acala: https://github.com/AcalaNetwork/Acala/blob/master/modules/transaction-payment/src/lib.rs
Bifrost: https://github.com/bifrost-finance/bifrost/blob/develop/pallets/flexible-fee/src/lib.rs
HydraDX: https://github.com/galacticcouncil/warehouse/blob/main/transaction-multi-payment/src/lib.rs

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-summit-24-boosting-the-developer-experience/7202/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants