fix checks order when registering parachain (#1177)

paritytech · Apr 10, 2024 · e5b5679 · e5b5679
1 parent a635048
commit e5b5679
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/bridges/relays/bin-substrate/src/cli/register_parachain.rs b/bridges/relays/bin-substrate/src/cli/register_parachain.rs
@@ -273,13 +273,13 @@ async fn wait_para_state<Relaychain: Chain>(
 					Relaychain::NAME,
 				)
 			})?;
-		if !from_states.contains(&para_state) {
-			return Err(anyhow::format_err!("Invalid parachain lifecycle: {:?}", para_state))
-		}
 		if para_state == to_state {
 			log::info!(target: "bridge", "Parachain state is now: {:?}", to_state);
 			return Ok(())
 		}
+		if !from_states.contains(&para_state) {
+			return Err(anyhow::format_err!("Invalid parachain lifecycle: {:?}", para_state))
+		}
 
 		log::info!(target: "bridge", "Parachain state: {:?}. Waiting for {:?}", para_state, to_state);
 		async_std::task::sleep(Relaychain::AVERAGE_BLOCK_INTERVAL).await;