Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot Opengov tests #96

Merged
merged 6 commits into from
Jul 20, 2023
Merged

Polkadot Opengov tests #96

merged 6 commits into from
Jul 20, 2023

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Mar 10, 2023

Test cases:

  • open HRMP channels, Collectives <> Statemint
  • set_desired_candidates on Stateming from RelayChain as StakingAdmin
  • init the Fellowship on Collectives from RelayChain as FellowshipAdmin
  • whitelist call on RelayChain from Collectives as Fellows
  • resume_xcm_execution on Statemint from Collectives as Fellows

@muharem muharem changed the title Muharem opengov fellowship Polkadot Opengov and Fellowship tests Mar 10, 2023
@muharem muharem changed the title Polkadot Opengov and Fellowship tests Polkadot Opengov tests Mar 10, 2023
@muharem muharem marked this pull request as ready for review July 20, 2023 14:26
@NachoPal
Copy link
Contributor

To be consistent with the rest of the tests could you use result pattern instead of attributes?

It is less verbose and easier to see the expected results.

@muharem
Copy link
Contributor Author

muharem commented Jul 20, 2023

To be consistent with the rest of the tests could you use result pattern instead of attributes?

It is less verbose and easier to see the expected results.

I will create a different PR for it

@@ -33,10 +25,26 @@ cumulus_based = true
name = "collator1"
ws_port = 9710
command = "./bin/polkadot-parachain"
args = [ "-lxcm=trace", "--state-cache-size=0" ]
args = ["-lxcm=trace"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove --state-cache-size=0 it is essential to avoid having to add delays between actions making the tests more slow

@NachoPal NachoPal merged commit 72680e1 into master Jul 20, 2023
NachoPal added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants