rpc_module: remove expect in fn call
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
May 18, 2022
| } | ||
|
|
||
| unreachable!("Invalid JSON-RPC response is not possible using jsonrpsee; this is bug please file an issue"); | ||
| let res = match serde_json::from_str::<Response<T>>(&resp) { |
There was a problem hiding this comment.
just annoying to have to do that let res binding but otherwise rustc complains about the lifetime issues FYI
There was a problem hiding this comment.
That's strange; I would have expected you could return the match immediately!
There was a problem hiding this comment.
me too but might confuse rustc that resp is borrowed twice ^^
TarikGul
approved these changes
May 18, 2022
jsdw
approved these changes
May 19, 2022
lexnv
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is mainly used for testing but the
expectthere was bad and confusing which this fixes.See #773 for further information.