Add timeouts to the futures in tests #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit worried by the fact that CI jobs sometimes get stuck on their own.
I think it may be a signal of some hard-to-get but yet dangerous issue (or some kind of misconfiguration).
This PR adds
560-second timeout to the futures spawned in tests, so it will be easier to get enough information and probably find the common pattern in these failures. Also, with it jobs will fail fast, without having to wait for the timeout.