feat(server): add Methods::extensions/extensions_mut
#1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RpcModule/Methods may need to inject extensions which could be injected by the implementation as Extensions. This PR adds additional API to be used for unit testing a RpcModule. For instance one may inject some arbitary data which can't be unit tested unless it's explictly injected by the RpcModule.
jsdw
approved these changes
Aug 12, 2024
niklasad1
commented
Aug 12, 2024
niklasad1
changed the title
Methods::inject_extensionsMethods::with_extensions
niklasad1
commented
Aug 14, 2024
niklasad1
changed the title
Methods::with_extensionsMethods::extensions/extensions_mut
niklasad1
commented
Aug 14, 2024
| let params = Params::new(params.as_ref().map(|params| params.as_ref().get())); | ||
| let max_response_size = usize::MAX; | ||
| let conn_id = ConnectionId(0); | ||
| extensions.insert(conn_id); | ||
| let mut ext = self.extensions.clone(); | ||
| ext.insert(conn_id); |
There was a problem hiding this comment.
we could actually inject this dummy connection in the constructor but I don't want to add the overhead for stuff that isn't using it.
niklasad1
commented
Aug 14, 2024
| @@ -213,6 +213,7 @@ impl Debug for MethodCallback { | |||
| #[derive(Default, Debug, Clone)] | |||
| pub struct Methods { | |||
| callbacks: Arc<FxHashMap<&'static str, MethodCallback>>, | |||
| extensions: Extensions, | |||
There was a problem hiding this comment.
This is cheap, the default is just Option::None,
jsdw
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RpcModule/Methods may need to inject extensions which could be needed by the RPC implementations.
For example in substrate I have moved the
deny unsafe stuffto an extension but the unit tests fails because it's needs be added by the RpcModule.Thus, this PR adds additional API to be used for unit testing a RpcModule. For instance one may inject some arbitary data which can't be unit tested unless it's explictly injected by the RpcModule.