Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client+transport)!: split tls into tls andtls-rustls-platform-verifier features #1419

Merged
merged 2 commits into from
Jul 4, 2024
Merged

refactor(client+transport)!: split tls into tls andtls-rustls-platform-verifier features #1419

merged 2 commits into from
Jul 4, 2024

Conversation

oleonardolima
Copy link
Contributor

fixes #1407

@oleonardolima oleonardolima requested a review from a team as a code owner June 28, 2024 13:54
@oleonardolima oleonardolima mentioned this pull request Jun 28, 2024
Closed
@tvolk131
Copy link

Thanks for pushing this through Leonardo!

@oleonardolima
Copy link
Contributor Author

I guess it will need another feature tls-custom, in order to properly handle the Default trait for both WsTranportBuilder and WsClientBuilder

@oleonardolima oleonardolima force-pushed the fix/add-rustls-platform-verifier-feature branch from 7bd0601 to 056e0e1 Compare June 28, 2024 14:31
@oleonardolima
refactor(client+transport)!: split tls into tls and
db13afa 
`tls-rustls-platform-verifier` features
@oleonardolima oleonardolima force-pushed the fix/add-rustls-platform-verifier-feature branch from 056e0e1 to db13afa Compare June 28, 2024 14:39
@niklasad1 niklasad1 requested a review from a team June 28, 2024 15:54
This was referenced Jun 28, 2024
Merged
Merged
@oleonardolima oleonardolima force-pushed the fix/add-rustls-platform-verifier-feature branch from b991d30 to db13afa Compare June 30, 2024 14:06
@oleonardolima oleonardolima mentioned this pull request Jun 30, 2024
Closed
@oleonardolima oleonardolima force-pushed the fix/add-rustls-platform-verifier-feature branch from 5631674 to 5756e62 Compare July 1, 2024 12:32
@niklasad1 niklasad1 requested a review from lexnv July 1, 2024 12:36
lexnv
lexnv approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing! 🙏

@niklasad1 niklasad1 merged commit 6bc58fe into paritytech:master Jul 4, 2024
10 checks passed
@oleonardolima oleonardolima deleted the fix/add-rustls-platform-verifier-feature branch July 4, 2024 11:37
@oleonardolima
Copy link
Contributor Author

@niklasad1 just to have an idea, when are you planning to cut a new release/patch?

@niklasad1
Copy link
Member

@niklasad1 just to have an idea, when are you planning to cut a new release/patch?

Good question, I don't think that we can't make a patch release unfortunately because code with the explicit --feature tls will break existing code but I haven't planned another release "soon" and I would like to fix a few more things before releasing v1.0 (I'll be AFK for a few weeks).

Do you need another release soon? We could also release v0.24, what do you say @lexnv?

@oleonardolima
Copy link
Contributor Author

Thanks! Yes, a new release soon would be helpful, as it would allow the usage of onion addresses on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.23.0 tls feature relies on rustls-platform-verifier, bringing other unwanted dependencies
4 participants
@oleonardolima @tvolk131 @niklasad1 @lexnv