Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc module): inject mocked ConnectionId in extensions without transport #1399

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix(rpc module): inject mocked ConnectionId in extensions without transport #1399

merged 1 commit into from
Jun 10, 2024

Conversation

niklasad1
Copy link
Member

This is useful for instance if one writes unit tests and in such scenario the ConnectionId was missing because
no "transport exist".

@niklasad1 niklasad1 requested a review from a team as a code owner June 10, 2024 13:57
@niklasad1 niklasad1 changed the title fix(rpc module): inject mocked ConnectionId in extensions fix(rpc module): inject mocked ConnectionId in extensions without transport Jun 10, 2024
@niklasad1 niklasad1 merged commit 207dd63 into master Jun 10, 2024
11 checks passed
@niklasad1 niklasad1 deleted the na-inject-conn-id-in-ext-rpc-module branch June 10, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasad1 @lexnv