Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject connection id in extensions #1381

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

niklasad1
Copy link
Member

Fixes #1306 (comment)

I introduced a wrapper type ConnectionId to avoid collisions in the extensions because those the builtin rustc types may used by users and they might unintentionally overwrite usize for some else....

@niklasad1 niklasad1 requested a review from a team as a code owner May 29, 2024 12:14
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niklasad1 niklasad1 merged commit b6d94c7 into master May 29, 2024
11 checks passed
@niklasad1 niklasad1 deleted the na-inject-conn-id-in-ext branch May 29, 2024 14:07
@niklasad1 niklasad1 mentioned this pull request Jun 6, 2024
@niklasad1 niklasad1 restored the na-inject-conn-id-in-ext branch June 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants