refactor(server): remove needless clone in ws background task
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Sep 15, 2023
| async fn execute_unchecked_call<L: Logger>( | ||
| params: Arc<ExecuteCallParams<L>>, | ||
| data: Vec<u8>, | ||
| bounded_subscriptions: BoundedSubscriptions, |
There was a problem hiding this comment.
Nice catch 👍
Would be interesting to see how big the performance improvement is, since I would expect the BoundedSubscriptions clone to be cheap (contains an Arc<..> and a u64)
There was a problem hiding this comment.
yeah, shouldn't matter in practice but found it when I was debugging stuff :P
lexnv
approved these changes
Sep 15, 2023
jsdw
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.