This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix experimental aura config and comment tests
#3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B0-silent
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
changed the title
aura configaura config and comment tests
gilescope
approved these changes
Aug 24, 2023
gilescope
reviewed
Aug 24, 2023
| @@ -185,6 +185,7 @@ fn limited_teleport_native_assets_from_relay_to_system_para_works() { | |||
| /// Limited Teleport of native asset from System Parachain to Relay Chain | |||
| /// should work when there is enough balance in Relay Chain's `CheckAccount` | |||
| #[test] | |||
| #[cfg(feature = "FIXME-IGNORED")] // <https://github.com/paritytech/cumulus/issues/3027> | |||
There was a problem hiding this comment.
Agreed seems fine as long as runtime-benchmarks is not enabled:
Suggested change
| #[cfg(feature = "FIXME-IGNORED")] // <https://github.com/paritytech/cumulus/issues/3027> | |
| #[cfg(not(feature = "runtime-benchmarks"))] // <https://github.com/paritytech/cumulus/issues/3027> |
There was a problem hiding this comment.
The crate does not have that feature and is also not propagating it downwards...
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
ordian
approved these changes
Aug 24, 2023
| @@ -124,6 +124,8 @@ impl pallet_aura::Config for Test { | |||
| type MaxAuthorities = ConstU32<100_000>; | |||
| type DisabledValidators = (); | |||
| type AllowMultipleBlocksPerSlot = ConstBool<false>; | |||
| #[cfg(feature = "experimental")] | |||
| type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>; | |||
There was a problem hiding this comment.
Is there a difference between this and ConstU64<SLOT_DURATION>? @rphmeier
There was a problem hiding this comment.
Not in practice. Though semantically they have different meanings.
There was a problem hiding this comment.
Does the change look good to you @rphmeier? The MR is looking for review approvals since we want to do the monorepo migration tomorrow.
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(preparation for the monorepo)
Changes:
experimentalfeature is enabled in the workspace, thenpallet-auraexpects an additional config item.runtime-benchmarksfeature is enabled in the workspace. Fix all ignored system parachain integration tests #3027 is linked in the code.