Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Flexibility in xcm-emulator methods #3037

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

girazoki
Copy link
Contributor

This PR decouples the accountId type from the accountId32 type and rather makes emulator methods depend on the accountId type defined by the chain runtime in question. This is important if we want the emulator to stay compatible with chains that have 20 byte accounts like Moonbeam.

The only method I did not change is account_id_of, because it is tied to sr25519 account generation. In any case this method is not that crucial because 20 byte account senders and receivers can be declared with the parameter_types! macro.

Kusama address: HZetxGJ1k9kJdNwHFHUn3i2Xk11jqiX6kRG89BJZXcNAm8z

@bkchr bkchr requested a review from NachoPal August 21, 2023 14:09
@@ -76,6 +76,8 @@ pub use xcm::{
};
pub use xcm_executor::traits::ConvertLocation;

pub type RuntimeAccountId<T> = <T as frame_system::Config>::AccountId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we could call it AccountIdOf?

@gilescope gilescope added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants