This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
chain-spec: support for json config/patch (and GenesisBuilder API)
#2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
…ort-for-genesis-builder-api
Copy of current chain_spec files (using deprecated from_genesis) was created in order to test json-patching vs old from_genesis version.
michalkucharczyk
added
A3-in_progress
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
michalkucharczyk
commented
Aug 1, 2023
| @@ -1229,6 +1230,16 @@ impl_runtime_apis! { | |||
| Ok(batches) | |||
| } | |||
| } | |||
|
|
|||
| impl sp_genesis_builder::GenesisBuilder<Block> for Runtime { | |||
There was a problem hiding this comment.
Do we need disable-genesis-builder feature here?
Refer to this
michalkucharczyk
added
A0-please_review
michalkucharczyk
commented
Aug 1, 2023
| @@ -86,6 +86,7 @@ pub fn get_chain_spec_with_extra_endowed( | |||
| id: ParaId, | |||
| extra_endowed_accounts: Vec<AccountId>, | |||
| ) -> ChainSpec { | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
leftover: migrate to builder()
|
bot rebase |
…ort-for-genesis-builder-api
|
Rebased |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for: paritytech/substrate#14562
Step towards: paritytech/polkadot-sdk#25