Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transfer asset via bridge with pallet xcm #2762

Open
wants to merge 412 commits into
base: master
Choose a base branch
from
Open

Transfer asset via bridge with pallet xcm #2762

wants to merge 412 commits into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 20, 2023 •
edited
Loading

Relates to: #2528 (BridgeHub for Kusama/Polkadot) - real bridging comes here

PR introduces:

  • xcm routing configuration for bridging between AssetHubKusama <-> AssetHubPolkadot
    • explicitly is allowed only reserve based transfer for KSM/DOT to cross-consensus AssetHubs and nothing else at first (lets start defensively)
      • if we decided, we can allow whatever (ETH, TrustBackedAssets, ForeignAssets, PoolAssets ...)
  • tests for simulation limited_reserve_transfer_assets with pallet_xcm both ways + handling ReserveAssetDeposisted on both sides
  • local zomienet run for: (check parachains/runtimes/bridge-hubs/README.md in this PR)
    • reserve based transfer of KSMs from AHK to AHP
    • reserve based transfer of DOTs from AHP to AHK

TODOs:

  • set filters for "reserve asset transfer" on both sides
  • add xcm-emulator tests

bkontur and others added 30 commits December 22, 2022 12:52
@bkontur
Added withdraw/deposit to bridge's reserve account
e127426
@bkontur
TODO: temporary hack pipelines because of paritytech/devops#2190
a7dd1fc
@KiChjang
Merge remote-tracking branch 'origin/master' into gav-xcm-v3
2f39d75
@bkontur @KiChjang
xcm-v3 benchmarks, weights, fixes for bridge-hubs (#2035)
5cdc48a 
* Dumy weights to get compile

* Change UniversalLocation according to paritytech/polkadot#4097 (Location Inversion Removed)

* Fix bridge-hubs weights

* ".git/.scripts/bench-bot.sh" pallet statemine assets pallet_xcm

* ".git/.scripts/bench-bot.sh" pallet statemint assets pallet_xcm

* ".git/.scripts/bench-bot.sh" pallet collectives-polkadot collectives pallet_xcm

* ".git/.scripts/bench-bot.sh" pallet westmint assets pallet_xcm

* ".git/.scripts/bench-bot.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::generic

* ".git/.scripts/bench-bot.sh" xcm bridge-hub-kusama bridge-hubs pallet_xcm_benchmarks::fungible

* ".git/.scripts/bench-bot.sh" pallet bridge-hub-kusama bridge-hubs pallet_xcm

* ".git/.scripts/bench-bot.sh" pallet bridge-hub-rococo bridge-hubs pallet_xcm

* ".git/.scripts/bench-bot.sh" xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::fungible

* ".git/.scripts/bench-bot.sh" xcm bridge-hub-rococo bridge-hubs pallet_xcm_benchmarks::generic

* Change NetworkId to Option<NetworkId>

Co-authored-by: command-bot <>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@KiChjang
Merge branch 'master' into gav-xcm-v3
7f3727f
@girazoki
Add event for showing the hash of an UMP sent message (#1228)
e2a3354 
* Add UpwardMessageSent event in parachain-system

* additional fixes

* Message Id

* Fix errors from merge

* fmt

* more fmt

* Remove todo

* more formatting
@KiChjang
Merge branch 'master' into gav-xcm-v3
b7970c3
@KiChjang
Fixes
63a18c2
@KiChjang
Fixes
f9a0390
@KiChjang
Fixes
893bc5c
@KiChjang
Fixes
e303fb2
@bkontur
Allow receive bridged Xcm::Trap on Westmint
2ff5c4f
@bkontur
Allow (temporary) Statemine send xcm messages
18ad58b
@bkontur
refactor TrustedBridgedNetworks
fe7817e
@bkontur
Allow (hacky) xcm::transact for remark/remark_with_event
a80781e
@bkontur
Unit-test for Statemine - send_xcm_transact_with_remark_with_event_works
0985898
@bkontur
Fix for BridgedSignedAccountId32AsNative
c3195d2
@KiChjang
Allow explicit unpaid executions from the relay chains for system par…
8fe432b 
…achains (#2060)

* Allow explicit unpaid executions from the relay chains for system parachains

* Put origin-filtering barriers into WithComputedOrigin

* Use ConstU32<8>

* Small nits

* formatting

* cargo fmt
@KiChjang
Merge remote-tracking branch 'origin/master' into gav-xcm-v3
e28ef3c
@KiChjang
Allow receiving XCMs from any relay chain plurality
87e0ea1
@KiChjang
Fixes
146c742
@joepetrowski
don't rename pallet in runtime
3353263
@joepetrowski
don't rename and fix tests
9e211b8
@bkontur
Added allowed_target_location + reanchored assets/destination + tests
31bc1c6
@joepetrowski
fix benchmark helper
25c2fc5
@joepetrowski
fix benchmark build
a4a581b
@bkontur
Merge remote-tracking branch 'origin/joe-bridge-hub-westmint-assets' …
7fbfeb3 
…into bko-transfer-asset-via-bridge
@joepetrowski
more benchmark fixes
9cd2708
@bkontur
Merge remote-tracking branch 'origin/joe-bridge-hub-westmint-assets' …
23f9e4d 
…into bko-transfer-asset-via-bridge
@joepetrowski
fix penpal and rococo
81e9703
joepetrowski
joepetrowski reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me now. Want to take one more pass over it before approving.

parachains/runtimes/assets/common/src/matching.rs Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 31, 2023 12:31
@bkontur @joepetrowski
Update parachains/runtimes/assets/common/src/matching.rs
ce84eb0 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
vstam1
vstam1 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkontur bkontur mentioned this pull request Aug 1, 2023
Merged
9 tasks
bkontur and others added 3 commits August 2, 2023 11:03
@paritytech-ci paritytech-ci requested a review from a team August 2, 2023 09:25
@bkontur bkontur mentioned this pull request Aug 3, 2023
Closed
12 tasks
@bkontur bkontur mentioned this pull request Aug 11, 2023
Open
6 tasks
@bkontur
Copy link
Contributor Author

bkontur commented Aug 16, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 16, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400918 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 36-2df042da-f065-40c9-af94-7c82c6d07ad7 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 16, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400918 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3400918/artifacts/download.

@acatangiu acatangiu mentioned this pull request Aug 25, 2023
Closed
4 tasks
@acatangiu acatangiu mentioned this pull request Aug 28, 2023
Closed
@bkontur bkontur mentioned this pull request Sep 1, 2023
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C7-critical PR touches the given topic and has a critical impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Security Audit (PRs) - SRLabs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bkontur @vstam1 @joepetrowski @KiChjang @girazoki @muharem @svyatonik @serban300 @acatangiu