Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update weights with VM runners #2712

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Update weights with VM runners #2712

merged 12 commits into from
Aug 1, 2023

Conversation

mateo-moon
Copy link
Contributor

  • Update weights using VM instances
  • Change runner tag for weights ci job to weights-vm

cc: paritytech/ci_cd#697

@mateo-moon mateo-moon added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 8, 2023
@mateo-moon mateo-moon requested a review from a team as a code owner June 8, 2023 10:40
@mateo-moon mateo-moon self-assigned this Jun 8, 2023
@mateo-moon mateo-moon requested a review from a team as a code owner June 8, 2023 10:40
@mateo-moon mateo-moon force-pushed the oleg/ci-cd/weights-vm branch 2 times, most recently from 2a468ea to 9ed3fe0 Compare June 8, 2023 10:50
@mateo-moon
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Jun 8, 2023

Here's a link to docs

 - Update weights using VM instances
 - Change runner tag for weights ci job to weights-vm
@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all

@command-bot
Copy link

command-bot bot commented Jun 9, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962582 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-7a48ce30-bef9-48df-9ad0-605ab0bdd99b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 9, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962582 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962582/artifacts/download.

@mateo-moon
Copy link
Contributor Author

bot bench-vm -v PIPELINE_SCRIPTS_REF=mak-remove-p-cumulus-all $ all

@command-bot
Copy link

command-bot bot commented Jun 9, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962657 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-1934620b-442c-49ee-851f-452c2b887c0a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 9, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962657 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2962657/artifacts/download.

@ggwpez
Copy link
Member

ggwpez commented Jun 12, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@ggwpez
Copy link
Member

ggwpez commented Jun 12, 2023

bot bench-vm -v PIPELINE_SCRIPTS_REF=mak-remove-p-cumulus-all $ all

@command-bot
Copy link

command-bot bot commented Jun 12, 2023

@ggwpez Exception caught in webhook handler
Can't find a revision of https://github.com/paritytech/command-bot-scripts/#mak-remove-p-cumulus-all

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all

@command-bot
Copy link

command-bot bot commented Jun 12, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2971038 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-24152a16-4494-4533-8206-e0a2c0a3ebaf to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 12, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2971038 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2971038/artifacts/download.

@bkontur
Copy link
Contributor

bkontur commented Jun 15, 2023

when merged #2741
pallet_assets should work

@bkontur
Copy link
Contributor

bkontur commented Jun 15, 2023

@ggwpez
bump substrate is merged,
but lets wait for this: #2732 and jobs here: #2741

because, it should generate to separate files for two instances of pallet_assets
when this is merged: #2743

@bkontur
Copy link
Contributor

bkontur commented Jul 11, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur
Copy link
Contributor

bkontur commented Jul 11, 2023

bot bench $ all

@command-bot
Copy link

command-bot bot commented Jul 11, 2023

@bkontur https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3168418 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 25-b2dd6ce0-b49d-4234-a151-90fa2aee6e1f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 12, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3168418 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3168418/artifacts/download.

@bkontur
Copy link
Contributor

bkontur commented Jul 22, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur
Copy link
Contributor

bkontur commented Jul 22, 2023

@oleg-plakida @ggwpez
finally, all cumulus benchmarks are fixed,
so now this should work,
they passed all here #2846

@mateo-moon
Copy link
Contributor Author

bot bench $ all

@command-bot
Copy link

command-bot bot commented Jul 24, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3246773 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-d2c605e0-5d41-4afe-aede-f085ae1aa0e7 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 24, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" all has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3246773 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3246773/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jul 24, 2023

@paritytech-cicd-pr Requester could not be detected as a member of an allowed organization.

@bkontur
Copy link
Contributor

bkontur commented Jul 25, 2023

@vstam1 @franciscoaguirre
guys, was there any recent change in pallet_xcm benchmarks that moved initiate_reserve_withdraw/reserve_asset_deposited from pallet_xcm_benchmarks_generic.rs to file pallet_xcm_benchmarks_fungible.rs ?

aha, ok, I see:

e628e48671 ("Change Fixed to WeightInfoBounds for Polkadot (#7077)", 2023-07-19)

@bkontur
Copy link
Contributor

bkontur commented Jul 25, 2023

@vstam1 @franciscoaguirre guys, was there any recent change in pallet_xcm benchmarks that moved initiate_reserve_withdraw/reserve_asset_deposited from pallet_xcm_benchmarks_generic.rs to file pallet_xcm_benchmarks_fungible.rs ?

aha, ok, I see:

e628e48671 ("Change Fixed to WeightInfoBounds for Polkadot (#7077)", 2023-07-19)

will be fixed here: #2934

@bkontur
Copy link
Contributor

bkontur commented Jul 27, 2023

bot bench $ all

@command-bot
Copy link

command-bot bot commented Jul 27, 2023

@bkontur Positional arguments are not supported anymore. I guess you meant bot bench cumulus-assets --pallet=all, but I could be wrong.
Read docs to find out how to run your command.

@mateo-moon
Copy link
Contributor Author

bot bench-all cumulus

@command-bot
Copy link

command-bot bot commented Jul 31, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3296669 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=cumulus. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-80fa5542-3a4d-4c6b-be2a-6f37dbe7312e to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 31, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --target_dir=cumulus has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3296669 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3296669/artifacts/download.

@mateo-moon mateo-moon merged commit b3c9889 into master Aug 1, 2023
3 checks passed
@mateo-moon mateo-moon deleted the oleg/ci-cd/weights-vm branch August 1, 2023 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants