Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use default for intergration test relay runtimes #2616

Merged
merged 1 commit into from
May 23, 2023

Conversation

gilescope
Copy link
Contributor

If people are using zombienet with a relay chain that has sudo added to it (for testing) then this is one additional place that sudo: Default::default() does not need to be added (it's sufficient to add the sudo pallet to the polkadot repo E.g. the -fast-sudo branches).

@gilescope gilescope added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 22, 2023
@gilescope gilescope requested a review from NachoPal May 23, 2023 11:12
@bkontur
Copy link
Contributor

bkontur commented May 23, 2023

I dont know if it is worth or desired to check this way all genesis chain specs here `polkadot-parachain/src/chain_spec/*.rs,
pros is when you add new pallet then you dont need to change it here, but this can be also cons

@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 80ca5ee into master May 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the giles-default-integration-tests branch May 23, 2023 14:53
ordian added a commit that referenced this pull request May 23, 2023
* master: (75 commits)
  Add Foreign Assets to Statemint (#2540)
  Bump casey from 0.3.3 to 0.4.0 (#2619)
  Companion for substrate#14188 (Add genesis config to Glutton pallet) (#2612)
  Use default for test relay runtimes (#2616)
  use `WasmExecutionMethod::default()` (#2622)
  Bump Swatinem/rust-cache from 2.3.0 to 2.4.0 (#2617)
  Do not assume `AssetId`s are `Copy` (companion for substrate#14158) (#2586)
  NFT Fractionalization on Westmint (#2600)
  Try-runtime proper return types (#2615)
  Nfts on Statemint (#2595)
  Update substrate/polkadot + needed changes to compile (#2613)
  Chainspecs: Fix bootnode address (#2611)
  Bump Swatinem/rust-cache from 2.2.1 to 2.3.0 (#2582)
  Bump ruby/setup-ruby from 1.148.0 to 1.149.0 (#2581)
  update WasmExecutionMethod (#2599)
  Switch to `relay_dispatch_queue_remaining_capacity` (#2608)
  Update syn (#2605)
  Update README.md (#2603)
  [Feature] XCM-Emulator (#2447)
  Removed Cargo.lock from subtreee (#2604)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants