Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Cleanup dependencies + dead code #2302

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Mar 10, 2023

  • Clean up some unused dependencies.
  • Remove AuxStore trait impl since we removed the subsystem that required it (also done in Allow integrated relay chain light client #2270, but I am waiting on that one)
  • Remove some polkadot-service dependencies where possible. In the long run I would like to remove as many polkadot-service dependencies as possible to allow compilation of collator nodes without compiling polkadot-runtime (in rpc and light-client mode). Currently not possible as the minimal node depends on it.

@skunert skunert added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 10, 2023
@skunert skunert requested a review from a team March 10, 2023 11:48
@dmitry-markin dmitry-markin requested a review from a team March 10, 2023 14:37
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skunert skunert merged commit 579dd3b into paritytech:master Mar 10, 2023
vieira-giulia pushed a commit that referenced this pull request Mar 13, 2023
@skunert skunert deleted the dependency-cleanup branch March 13, 2023 21:56
ordian added a commit that referenced this pull request Mar 16, 2023
* master: (44 commits)
  Companion for #13287 (#2155)
  timestamp ci job logs (#2327)
  Release parachain host API v4 (#2325)
  Bump clap from 4.1.6 to 4.1.8 (#2272)
  Enabled `polkadot-parachain` build for `runtime-benchmarks`, e.g.: (#2324)
  Bump tokio from 1.25.0 to 1.26.0 (#2273)
  Bump async-trait from 0.1.64 to 0.1.66 (#2318)
  ReadMe followup for  #2313 (#2317)
  Fix runtime api import path (#2319)
  Update Westend collectives chainspec (#2311)
  README: Document usage of RPC node (#2313)
  Companion for paritytech/substrate#13592 (#2310)
  Update orchestra and metered-channel (#2304)
  Backport: Brigehub: Add in force upgrade xcm version (into master) (#2289)
  [Backport] version bumps from 9380 (#2309)
  Bump proc-macro2 from 1.0.50 to 1.0.52 (#2312)
  Remove use of trait Store (#2286)
  Companion for #13482 (#2303)
  add amforc bootnodes (#2246)
  Cleanup dependencies + dead code (#2302)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants