Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add Support for Foreign Assets #2133

Merged
merged 30 commits into from
Mar 23, 2023
Merged

Add Support for Foreign Assets #2133

merged 30 commits into from
Mar 23, 2023

Conversation

joepetrowski
Copy link
Contributor

@joepetrowski joepetrowski commented Jan 24, 2023 •
edited
Loading

Adds support to Statemine and Westmint for foreign fungible assets. This will allow other parachains to represent their assets, as well as bridges to represent assets from other networks, on Statemine. A follow up PR will introduce this to Statemint once it has been audited and in the Kusama coal mines for some time.

@joepetrowski joepetrowski added A3-in_progress Pull request is in progress. No review needed at this stage. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 24, 2023
@paritytech-ci paritytech-ci requested review from a team January 24, 2023 13:30
@joepetrowski joepetrowski added T7-system_parachains This PR/Issue is related to System Parachains. T6-XCM This PR/Issue is related to XCM. T8-bridges This PR/Issue is related to bridges. labels Jan 24, 2023
@bkontur
Copy link
Contributor

bkontur commented Jan 30, 2023

bot rebase

@joepetrowski joepetrowski added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jan 31, 2023
@joepetrowski
Copy link
Contributor Author

bot rebase

@joepetrowski
Copy link
Contributor Author

bot rebase

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/statemint-update-roadmap/1200/94

@gilescope gilescope mentioned this pull request Feb 13, 2023
Merged
@joepetrowski joepetrowski removed T7-system_parachains This PR/Issue is related to System Parachains. T6-XCM This PR/Issue is related to XCM. T8-bridges This PR/Issue is related to bridges. labels Feb 14, 2023
@bkontur
Copy link
Contributor

bkontur commented Feb 23, 2023

bot rebase

@bkontur
Copy link
Contributor

bkontur commented Feb 28, 2023

bot rebase

@bkontur
Copy link
Contributor

bkontur commented Mar 3, 2023

bot rebase

bkchr
bkchr approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a high level, haven't done an in depth review

parachains/runtimes/assets/westmint/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/common/src/matching.rs Outdated Show resolved Hide resolved
@bkontur
Copy link
Contributor

bkontur commented Mar 23, 2023 •
edited
Loading

bot rebase

1 similar comment
@bkontur
Copy link
Contributor

bkontur commented Mar 23, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkontur
Copy link
Contributor

bkontur commented Mar 23, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 020a024 into master Mar 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the joe-foreign-assets branch March 23, 2023 14:14
ordian added a commit that referenced this pull request Mar 23, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
e9327cd 
* master:
  Add Support for Foreign Assets (#2133)
  XCM V2 weight template (#2344)
  Companion for polkadot#6928 (#2356)
  move back to ci-linux@production image
@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 5, 2023
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/bridge-hub-questions/2693/2

@joepetrowski joepetrowski mentioned this pull request May 7, 2023
Merged
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

@IkerAlus IkerAlus mentioned this pull request May 30, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@joepetrowski joepetrowski mentioned this pull request Jul 18, 2023
Open
4 tasks
@Dinonard Dinonard mentioned this pull request Jul 19, 2023
Merged
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkontur bkontur bkontur left review comments

@gavofyork gavofyork gavofyork approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joepetrowski @bkontur @Polkadot-Forum @gavofyork @bkchr @louismerlin @muharem