This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[Enhancement] Use XCM V3 for initiate_teleport weight calc #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
added
A0-please_review
ruseinov
added
D5-nicetohaveaudit ⚠️
gavofyork
approved these changes
Feb 7, 2023
gilescope
approved these changes
Feb 7, 2023
KiChjang
reviewed
Feb 7, 2023
| Self::Wild(_) => weight.saturating_mul(MAX_ASSETS as u64), | ||
| Self::Wild(asset) => match asset { | ||
| All => weight.saturating_mul(MAX_ASSETS as u64), | ||
| AllOf { .. } => weight, |
There was a problem hiding this comment.
I'm actually still uncertain about this -- comments on AllOfCounted says that each individual instance of an NFT is considered a different class of asset, and so wouldn't it make more sense to use the number of NFT instances as an upper bound here?
There was a problem hiding this comment.
Hmm, good question. Let me check it out and come back to you.
There was a problem hiding this comment.
Yeah, I think this makes sense. I'm not sure though where the NFT instance count should be coming from in this case.
There was a problem hiding this comment.
So this requires you to actually look inside the holding register and determine just how many AssetInstances there are... We could match against fun in AllOf and see if it's a NonFungible, and if so, it would basically be weight * MaxAssetsIntoHolding::get(), otherwise it's just weight.
There was a problem hiding this comment.
@KiChjang One thing that disturbs me a bit is the comment below, should we then do something like weight * MaxAssetsIntoHolding::get() * 2 to be safe?
/// The maximum number of assets we target to have in the Holding Register at any one time.
///
/// NOTE: In the worse case, the Holding Register may contain up to twice as many assets as this
/// and any benchmarks should take that into account.
type MaxAssetsIntoHolding: Get<u32>;
|
bot rebase |
|
Rebased |
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
ru/enhancement/iinitinit-teleport
branch
bkontur
pushed a commit
that referenced
this pull request
Feb 25, 2023
* [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <>
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 27, 2023
) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 27, 2023
) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 27, 2023
) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Feb 27, 2023
) (#2239) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Feb 27, 2023
) (#2240) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
) (#2238) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
Closed
gilescope
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2402) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2403) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1669