Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move ExportGenesisStateCommand and ExportGenesisWasmCommand to cumulus-client-cli #1325

Merged
merged 6 commits into from
Jun 18, 2022
Merged

Move ExportGenesisStateCommand and ExportGenesisWasmCommand to cumulus-client-cli #1325

merged 6 commits into from
Jun 18, 2022

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Jun 2, 2022

Signed-off-by: koushiro koushiro.cqx@gmail.com

polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK

…s-client-cli

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Contributor Author

@bkchr @shawntabrizi PTAL

@koushiro
Copy link
Contributor Author

@KiChjang could you take a look this PR?

@shawntabrizi
Copy link
Member

Looks fine. What does it solve?

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes Q0-trivial labels Jun 14, 2022
@shawntabrizi shawntabrizi requested a review from bkchr June 14, 2022 02:42
@koushiro
Copy link
Contributor Author

If downstream users want to add these two commands, they don't need to implement them by themselves any more.

@koushiro
Copy link
Contributor Author

@bkchr could you take a look this PR? I wanna it could be included in the next polkadot release.

@bkchr
Copy link
Member

bkchr commented Jun 17, 2022

/tip small

@substrate-tip-bot
Copy link

A small tip was successfully submitted for koushiro (15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

@bkchr
Copy link
Member

bkchr commented Jun 17, 2022

@bkchr could you take a look this PR? I wanna it could be included in the next polkadot release.

Sorry for the delay. Merge master then I'm going to merge this.

@koushiro
Copy link
Contributor Author

@bkchr Done

@bkchr bkchr merged commit 7d0ae5e into paritytech:master Jun 18, 2022
@bkchr
Copy link
Member

bkchr commented Jun 18, 2022

Ty

@koushiro koushiro deleted the move-export-genesis-cmd branch June 18, 2022 13:59
jiguantong added a commit to darwinia-network/darwinia-parachain that referenced this pull request Jul 6, 2022
jiguantong added a commit to darwinia-network/darwinia-parachain that referenced this pull request Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants