Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Pull request is in clean status #12

Closed
Tracked by #7
Bullrich opened this issue Sep 28, 2023 · 0 comments · Fixed by #13
Closed
Tracked by #7

Error: Pull request is in clean status #12

Bullrich opened this issue Sep 28, 2023 · 0 comments · Fixed by #13
Assignees
@Bullrich
Labels
bug Something isn't working
Milestone
Version 1.0.0

Comments

@Bullrich
Copy link
Collaborator

If all the checks have been completed and the PR is ready to review, the action will fail when trying to enable auto-merge with the error Pull request is in clean status.

To solve this, we can use the mergePullRequest GraphQL endpoint instead if auto-merge is unavailable.
@Bullrich Bullrich added the bug Something isn't working label Sep 28, 2023
@Bullrich Bullrich added this to the Version 1.0.0 milestone Sep 28, 2023
@Bullrich Bullrich self-assigned this Sep 28, 2023
This was referenced Sep 28, 2023
Closed
Merged
@Bullrich Bullrich linked a pull request Sep 28, 2023 that will close this issue
Merge PR when checks are ready #13
Merged
Bullrich added a commit that referenced this issue Sep 28, 2023
@Bullrich
Merge PR when checks are ready (#13)
d7c5bf6 
There is an issue that you can not enable `auto-merge` when a PR is
ready to merge.

For this situation, I have added a try/catch block where it evaluates if
the error contains the message `Pull request is in clean status`. If so,
it will use the
[mergePullRequest](https://docs.github.com/en/graphql/reference/mutations#mergepullrequest)
mutation to merge the PR directly.

This fixes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging a pull request may close this issue.

Merge PR when checks are ready paritytech/auto-merge-bot
1 participant
@Bullrich