React and Preact recipes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinotonnina
suggested changes
Dec 6, 2017
jamiebuilds
reviewed
Dec 6, 2017
src/docs/recipes.md
Outdated
| // package.json | ||
| "scripts": { | ||
| "start": "parcel index.html" | ||
| } |
jamiebuilds
reviewed
Dec 6, 2017
src/docs/recipes.md
Outdated
| // package.json | ||
| "scripts": { | ||
| "start": "parcel index.html" | ||
| } |
devongovett
force-pushed
the
master
branch
3 times, most recently
from
fbf3279
to
1afb858
Compare
jakoblind
reviewed
Dec 7, 2017
src/layout/page.html
Outdated
| <a href="plugins.html">🔌 Plugins</a> | ||
| </li> | ||
| <li> | ||
| <a href="recipes.html">🍰 Recipes</a> |
There was a problem hiding this comment.
I don't think the Recipes section should be under "Advanced". It contains getting started recipes.
src/docs/recipes.md
Outdated
| [Blog Post](http://blog.jakoblind.no/react-parcel/) | ||
|
|
||
| ``` | ||
| npm install --save react react-dom npm install --save-dev parcel-bundler |
There was a problem hiding this comment.
each npm command should be on it's own row.
|
Also, should we have a link to these getting started recipes on the getting started page? (https://parceljs.org/getting_started.html) |
devongovett
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added React and Preact to recipes to the docs.