Add lazy/eager cache key to avoid invalid change when switching modes #9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also a cache key in |
marcins
approved these changes
Feb 1, 2024
| @@ -665,7 +665,8 @@ export default class PackagerRunner { | |||
| bundleGraph.getHash(bundle) + | |||
| JSON.stringify(configResults) + | |||
| JSON.stringify(globalInfoResults) + | |||
| this.options.mode, | |||
| this.options.mode + | |||
| `${this.options.shouldBuildLazily ? 'lazy' : 'eager'}`, | |||
There was a problem hiding this comment.
/nit but this doesn't really need to be a template string.. (but I get that you probably just copied what you did in all the other places, no big deal..)
| @@ -6788,4 +6790,43 @@ describe('cache', function () { | |||
| let res = await run(build.bundleGraph); | |||
| assert.deepEqual(res, {default: 'foo'}); | |||
| }); | |||
|
|
|||
| it('invalidates correctly when switching from lazy to eager modes', async function () { | |||
There was a problem hiding this comment.
I assume this was a failing test before your changes?
Yep, I also looked at the Parcel version variable |
JakeLane
commented
Feb 1, 2024
mattcompiles
approved these changes
Feb 1, 2024
JakeLane
force-pushed
the
jlane2/fix-dirty-cache-switch-lazy-mode
branch
from
0aa9f8f
to
a391e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Simple change to consider whether lazy mode is enabled/disabled. This is required because launching with
--lazy, then re-launching without--lazywill cause build errors.🚨 Test instructions
yarn parcel --lazyyarn parcel