-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reliance on requestTracker in loadGraphs #9440
Merged
irismoini
merged 15 commits into
v2
from
imoini/P2X-1172-remove-reliance-on-requestTracker
Dec 15, 2023
Merged
Remove reliance on requestTracker in loadGraphs #9440
irismoini
merged 15 commits into
v2
from
imoini/P2X-1172-remove-reliance-on-requestTracker
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorakong
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR changes the cache keys for the
requestGraph
,bundleGraph
, andassetGraph
by appending their corresponding names to the keys. This makes it easy to identify therequestGraph
,bundleGraph
, andassetGraph
files in the cache directory which is useful for Parcel-query'sloadGraph
function. This PR modifies theloadGraphs
function in Parcel-query to to load thebundleGraph
andassetGraph
without needing information from therequestTracker
to identitfy these graphs, thus removing the reliance on therequestTracker
.This PR is to set us up for future work where only necessary graphs are deserialized for a given Parcel query, i.e.
getBundles
does not require theassetGraph
and thus there's no need to spend time deserializing it.Note:
bundleInfo
still requires therequestTracker
. (No easy way to retrieve it outside ofrequestTracker
).💻 Examples
For example a cache key for the
requestGraph
that previously would have be represented likef067ed41c9e7c588
, is now represented asf067ed41c9e7c588-RequestGraph
. Same for thebundleGraph
andassetGraph
cache keys.Previously if an error occurred with deserializing or indentifying the
requestTracker
, thebundleGraph
andassetGraph
could not be fetched and queries likeinspectCache
would fail completely. Now you will get an output like the following:🚨 Test instructions
Tested manually with different queries and by inspecting the cache.
✔️ PR Todo