Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix for exiting early when identifying requestGraph in loadGraphs #9437

Conversation

irismoini
Copy link
Contributor

@irismoini irismoini commented Dec 13, 2023

↪️ Pull Request

The loadGraph function sorts the files in the cache by size and modification time and then iterates through these files to identify the requestGraph. Because the requestGraph is written to the cache with the setLargeBlob function, the file name always ends with '-0'. There's no need to waste time deserializing files that don't end with '-0' and checking to see if they are the requestGraph. However, there's currently a bug in this early stopping condition when identifying the requestGraph. This PR fixes that.

💻 Examples

🚨 Test instructions

Commented out the break condition and logged the files that could possibly being deserialized if the requestGraph wasn't found on the first try. Previously files that did not end with '-0' where being deserialized, now only files ending with '-0' will be.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@irismoini irismoini self-assigned this Dec 13, 2023
@irismoini irismoini merged commit 0980b25 into v2 Dec 13, 2023
14 of 16 checks passed
@irismoini irismoini deleted the imoini/minor-bug-fix-for-exiting-early-when-identifying-request-graph branch December 13, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants