Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify parcel query to not require all graphs on startup #9426

Merged

Conversation

irismoini
Copy link
Contributor

@irismoini irismoini commented Dec 7, 2023

↪️ Pull Request

This PR modifies Parcel-query so that it no longer strictly requires all of Parcel's graphs or bundleInfo on startup.

💻 Examples

For example you no longer need the bundle graph to do queries on the asset graph. If you run parcel-query with .stats and the bundleGraph is undefined you will now get the following output:

╔═════════════════════════════════════════╗
║        # Asset Graph Node Counts        ║
╟────────────────────┬────────────────────╢
║ asset              │ 33484              ║
╟────────────────────┼────────────────────╢
║ dependency         │ 144668             ║
╟────────────────────┼────────────────────╢
║ asset_group        │ 35048              ║
╚════════════════════╧════════════════════╝

Bundle Graph could not be found.

and Parcel-query will not exit. Previously the output would simply be

Bundle Graph could not be found

on startup and Parcel-query would exit.

🚨 Test instructions

Tested manually with different scenarios. i.e. setting assetGraph to undefined and running .getBundles

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@irismoini irismoini force-pushed the imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs branch from 680cf27 to b8f3790 Compare December 7, 2023 05:18
@irismoini irismoini force-pushed the imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs branch from b8f3790 to 94db58f Compare December 7, 2023 05:23
@irismoini irismoini self-assigned this Dec 7, 2023
@irismoini irismoini merged commit 5628da2 into v2 Dec 13, 2023
12 of 15 checks passed
@irismoini irismoini deleted the imoini/P2X-1171-modify-parcel-query-to-not-require-all-graphs branch December 13, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants