Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline constants in shared bundles #9313

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Fix inline constants in shared bundles #9313

merged 12 commits into from
Oct 18, 2023

Conversation

mattcompiles
Copy link
Contributor

↪️ Pull Request

Inline constant modules should be placed in bundles alongside their direct parents. This change ensures that works for for all cases, specifically shared bundles.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 11, 2023 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.87s +28.00ms
Cached 281.00ms -16.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.ff03421b.js 1.48kb +0.00b 459.00ms -52.00ms 🚀
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 459.00ms -52.00ms 🚀
dist/modern/index.4a29d309.js 921.00b +0.00b 458.00ms -53.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 496.00ms -40.00ms 🚀
dist/modern/index.html 749.00b +0.00b 496.00ms -38.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 307.00ms -24.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 307.00ms -23.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 318.00ms -16.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 4.80s -63.00ms
Cached 487.00ms +41.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 459.11kb +0.00b 1.18s +71.00ms ⚠️
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 517.00ms +100.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 517.00ms +100.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 516.00ms +99.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 368.00ms +73.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 459.11kb +0.00b 1.04s -59.00ms 🚀
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 397.00ms -28.00ms 🚀
dist/UserProfile.8945a243.js 1.38kb +0.00b 397.00ms -28.00ms 🚀
dist/NotFound.8b44a81d.js 269.00b +0.00b 397.00ms -28.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 42.29s -123.00ms
Cached 2.50s +52.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/refractor.3e0cc31b.js 598.96kb +0.00b 13.01s -1.68s 🚀
dist/media-viewer.38e3999a.js 536.13kb +0.00b 13.01s -1.68s 🚀
dist/popup.a77286c1.js 321.45kb +0.00b 13.01s -1.68s 🚀
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 9.31s -899.00ms 🚀
dist/EmojiPickerComponent.4a196252.js 188.61kb +0.00b 12.99s -1.70s 🚀
dist/card.d06de810.js 138.91kb +0.00b 11.82s +1.62s ⚠️
dist/ConfigPanelFieldsLoader.28b428a5.js 82.73kb +0.00b 12.89s -1.80s 🚀
dist/mobile-upload.f21df36e.js 66.34kb +0.00b 5.87s -387.00ms 🚀
dist/esm.34897092.js 62.95kb +0.00b 13.01s -1.68s 🚀
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 9.30s -907.00ms 🚀
dist/archive.c374f622.js 59.90kb +0.00b 13.01s -1.68s 🚀
dist/esm.bfca2115.js 59.30kb +0.00b 11.82s +1.62s ⚠️
dist/component-lazy.51d1dec9.js 58.94kb +0.00b 6.99s -374.00ms 🚀
dist/component.a781cbb6.js 57.16kb +0.00b 5.87s -389.00ms 🚀
dist/DatePicker.042aeb21.js 47.46kb +0.00b 7.05s -375.00ms 🚀
dist/esm.5e913efb.js 39.11kb +0.00b 13.01s -1.68s 🚀
dist/Modal.38d9f78c.js 27.83kb +0.00b 5.87s -384.00ms 🚀
dist/DatePicker.dd4c3679.js 24.96kb +0.00b 7.05s -375.00ms 🚀
dist/smartMediaEditor.efa59853.js 21.68kb +0.00b 13.04s -1.65s 🚀
dist/esm.aee9cbf1.js 20.43kb +0.00b 13.04s -1.65s 🚀
dist/component.c2c7f470.js 18.68kb +0.00b 5.87s -382.00ms 🚀
dist/js.e1035d4d.js 17.15kb +0.00b 5.87s -383.00ms 🚀
dist/ConfigPanelFieldsLoader.2b7c03be.js 15.74kb +0.00b 9.29s -908.00ms 🚀
dist/ui.8c117104.js 14.48kb +0.00b 9.29s -908.00ms 🚀
dist/ConfigPanelFieldsLoader.5dfde67d.js 13.63kb +0.00b 9.29s -908.00ms 🚀
dist/dropzone.77a8e729.js 13.40kb +0.00b 13.01s -1.68s 🚀
dist/pdfRenderer.4d43636e.js 11.90kb +0.00b 12.62s -1.79s 🚀
dist/dropzone.1c15cdc1.js 11.48kb +0.00b 13.01s -1.68s 🚀
dist/Toolbar.4d256e97.js 9.36kb +0.00b 13.04s -1.65s 🚀
dist/clipboard.400013a2.js 7.92kb +0.00b 13.01s -1.68s 🚀
dist/mobile-upload.3747b689.js 7.79kb +0.00b 5.87s -380.00ms 🚀
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 9.30s -908.00ms 🚀
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 11.82s +1.62s ⚠️
dist/mobile-upload.2102debb.js 7.79kb +0.00b 13.01s -1.68s 🚀
dist/index.runtime.431c5c90.js 7.29kb +0.00b 13.13s -1.58s 🚀
dist/browser.0009c8b4.js 7.19kb +0.00b 13.01s -1.68s 🚀
dist/index.b16227d6.css 4.08kb +0.00b 13.14s -1.59s 🚀
dist/Modal.850345b4.js 3.86kb +0.00b 5.87s -383.00ms 🚀
dist/component.360dba95.js 3.20kb +0.00b 5.87s -384.00ms 🚀
dist/media-viewer-analytics-error-boundary.60bdaa4c.js 3.18kb +0.00b 13.01s -1.68s 🚀
dist/media-picker-analytics-error-boundary.c493f011.js 3.18kb +0.00b 13.01s -1.68s 🚀
dist/media-card-analytics-error-boundary.74e0c7f9.js 3.18kb +0.00b 13.01s -1.68s 🚀
dist/png-chunks-extract.92497b2d.js 3.06kb +0.00b 5.87s -379.00ms 🚀
dist/ru.0cf3f40e.js 2.81kb +0.00b 9.29s -907.00ms 🚀
dist/uk.282f23b1.js 2.76kb +0.00b 9.29s -908.00ms 🚀
dist/codeViewerRenderer.51140ec8.js 2.61kb +0.00b 12.62s -2.07s 🚀
dist/th.137e1013.js 2.60kb +0.00b 9.29s -907.00ms 🚀
dist/ResourcedEmojiComponent.9a253c26.js 2.47kb +0.00b 7.05s -375.00ms 🚀
dist/pl.bce591be.js 2.25kb +0.00b 8.14s +716.00ms ⚠️
dist/cs.bf42283b.js 2.23kb +0.00b 7.05s -376.00ms 🚀
dist/de.90d5c4fa.js 2.17kb +0.00b 7.05s -376.00ms 🚀
dist/fr.ff5d335f.js 2.13kb +0.00b 7.05s -377.00ms 🚀
dist/es.80bf0476.js 2.12kb +0.00b 7.05s -376.00ms 🚀
dist/hu.223c2cde.js 2.10kb +0.00b 7.05s -377.00ms 🚀
dist/fi.98bb8fa8.js 2.09kb +0.00b 7.05s -377.00ms 🚀
dist/ja.7d4156df.js 2.09kb +0.00b 8.14s +715.00ms ⚠️
dist/vi.b46097db.js 2.09kb +0.00b 9.30s -907.00ms 🚀
dist/pt_BR.b9e37d37.js 2.06kb +0.00b 8.14s +715.00ms ⚠️
dist/tr.c85d90a9.js 2.03kb +0.00b 9.29s -907.00ms 🚀
dist/ko.9c6bf469.js 1.98kb +0.00b 8.14s +717.00ms ⚠️
dist/sv.1c06c95c.js 1.98kb +0.00b 9.29s -907.00ms 🚀
dist/it.04edb54a.js 1.97kb +0.00b 7.05s -377.00ms 🚀
dist/nb.9bd6db78.js 1.96kb +0.00b 8.14s +715.00ms ⚠️
dist/date.139a08b0.js 1.95kb +0.00b 6.25s -374.00ms 🚀
dist/da.d2d8303e.js 1.95kb +0.00b 7.05s -376.00ms 🚀
dist/nl.c4d12122.js 1.94kb +0.00b 8.14s +716.00ms ⚠️
dist/images.774ef3be.js 1.90kb +0.00b 6.25s -375.00ms 🚀
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 9.30s -907.00ms 🚀
dist/zh.b01fe721.js 1.84kb +0.00b 9.30s -907.00ms 🚀
dist/feedback.4b745631.js 1.76kb +0.00b 7.05s -376.00ms 🚀
dist/status.20808f9b.js 1.67kb +0.00b 6.25s -375.00ms 🚀
dist/code.3ce450f8.js 1.56kb +0.00b 6.25s -373.00ms 🚀
dist/workerHasher.4f6584da.js 1.56kb +0.00b 5.87s -380.00ms 🚀
dist/workerHasher.540c9790.js 1.56kb +0.00b 9.30s -908.00ms 🚀
dist/workerHasher.c840c607.js 1.56kb +0.00b 11.82s +1.62s ⚠️
dist/workerHasher.730f3766.js 1.56kb +0.00b 13.01s -1.68s 🚀
dist/workerHasher.9b1fcdbf.js 1.56kb +0.00b 13.01s -1.68s 🚀
dist/workerHasher.02b63a21.js 1.56kb +0.00b 13.01s -1.68s 🚀
dist/list-number.fdc97a50.js 1.47kb +0.00b 6.25s -375.00ms 🚀
dist/heading6.e6e03f52.js 1.36kb +0.00b 7.05s -377.00ms 🚀
dist/16.4998f52b.js 1.35kb +0.00b 5.87s -387.00ms 🚀
dist/heading3.73972e33.js 1.35kb +0.00b 6.25s -375.00ms 🚀
dist/16.330880f6.js 1.29kb +0.00b 5.87s -383.00ms 🚀
dist/link.71e06c5e.js 1.28kb +0.00b 6.25s -375.00ms 🚀
dist/emoji.8f9f45dc.js 1.25kb +0.00b 6.25s -375.00ms 🚀
dist/heading5.d2f94d9d.js 1.23kb +0.00b 7.05s -377.00ms 🚀
dist/expand.c983e90a.js 1.18kb +0.00b 7.05s -375.00ms 🚀
dist/heading2.c27d912d.js 1.17kb +0.00b 6.25s -375.00ms 🚀
dist/heading4.be08fc9e.js 1.12kb +0.00b 6.25s -1.11s 🚀
dist/mention.f4723418.js 1.09kb +0.00b 6.25s -375.00ms 🚀
dist/layout.b5e3a7ef.js 1.05kb +0.00b 6.25s -374.00ms 🚀
dist/divider.7bb33712.js 1.04kb +0.00b 6.25s -374.00ms 🚀
dist/action.c407ac14.js 1.02kb +0.00b 6.25s -373.00ms 🚀
dist/heading1.d7caae19.js 1.02kb +0.00b 6.25s -375.00ms 🚀
dist/16.371e251f.js 1.00kb +0.00b 5.87s -387.00ms 🚀
dist/list.bd698aa0.js 1011.00b +0.00b 6.25s -375.00ms 🚀
dist/quote.d6bda47a.js 1011.00b +0.00b 6.25s -374.00ms 🚀
dist/decision.a17a0d00.js 992.00b +0.00b 6.25s -374.00ms 🚀
dist/16.8adad466.js 980.00b +0.00b 5.87s -384.00ms 🚀
dist/16.71432140.js 980.00b +0.00b 5.87s -388.00ms 🚀
dist/panel-warning.772e8569.js 968.00b +0.00b 6.25s -373.00ms 🚀
dist/16.e5f05248.js 960.00b +0.00b 5.87s -383.00ms 🚀
dist/16.549c63e3.js 955.00b +0.00b 6.25s -376.00ms 🚀
dist/table.e0e68580.js 946.00b +0.00b 6.25s -375.00ms 🚀
dist/16.79864de1.js 920.00b +0.00b 5.87s -386.00ms 🚀
dist/panel.45c00b08.js 887.00b +0.00b 6.25s -374.00ms 🚀
dist/panel-error.bfda44fb.js 864.00b +0.00b 6.25s -375.00ms 🚀
dist/16.7d7d7930.js 862.00b +0.00b 5.87s -387.00ms 🚀
dist/16.4556c00f.js 834.00b +0.00b 5.87s -387.00ms 🚀
dist/16.a44bb474.js 827.00b +0.00b 5.87s -383.00ms 🚀
dist/16.bf9fb66d.js 821.00b +0.00b 6.25s -376.00ms 🚀
dist/panel-success.4afcba7a.js 805.00b +0.00b 6.25s -374.00ms 🚀
dist/panel-note.58ef2b52.js 795.00b +0.00b 6.25s -374.00ms 🚀
dist/16.dffb58fe.js 782.00b +0.00b 5.87s -387.00ms 🚀
dist/16.0118b1f8.js 776.00b +0.00b 5.87s -386.00ms 🚀
dist/16.9a311f76.js 776.00b +0.00b 5.87s -388.00ms 🚀
dist/16.edf70d70.js 775.00b +0.00b 5.87s -388.00ms 🚀
dist/16.4af9f37f.js 774.00b +0.00b 5.87s -383.00ms 🚀
dist/16.aa70dcce.js 773.00b +0.00b 5.87s -383.00ms 🚀
dist/16.c715b7e1.js 746.00b +0.00b 6.25s -376.00ms 🚀
dist/16.54ffa2b2.js 725.00b +0.00b 5.87s -383.00ms 🚀
dist/16.d7c3881b.js 697.00b +0.00b 5.87s -386.00ms 🚀
dist/sk.4be9c93f.js 656.00b +0.00b 9.29s -907.00ms 🚀
dist/pt_PT.e211e609.js 635.00b +0.00b 8.14s -1.83s 🚀
dist/et.88ef7cb4.js 633.00b +0.00b 7.05s -377.00ms 🚀
dist/simpleHasher.09765db3.js 589.00b +0.00b 5.87s -380.00ms 🚀
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 9.30s -908.00ms 🚀
dist/simpleHasher.23db7a52.js 589.00b +0.00b 11.82s +1.62s ⚠️
dist/simpleHasher.eefc98b4.js 589.00b +0.00b 13.01s -1.68s 🚀
dist/simpleHasher.47b9c809.js 589.00b +0.00b 13.01s -1.68s 🚀
dist/simpleHasher.cadc19c6.js 589.00b +0.00b 13.01s -1.68s 🚀
dist/is.5f045a22.js 495.00b +0.00b 7.05s -377.00ms 🚀
dist/ro.8d5b380a.js 482.00b +0.00b 8.16s -1.81s 🚀
dist/en_GB.4c40e6c6.js 472.00b +0.00b 7.05s -376.00ms 🚀
dist/en.e1d21f6d.js 469.00b +0.00b 7.05s -377.00ms 🚀
dist/index.html 248.00b +0.00b 13.17s +3.33s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/media-viewer.38e3999a.js 536.13kb +0.00b 13.26s +3.21s ⚠️
dist/index.html 248.00b +0.00b 13.48s +4.44s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 3.55s +23.00ms
Cached 397.00ms -23.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.25kb +0.00b 1.14s +67.00ms ⚠️

Click here to view a detailed benchmark overview.

@AGawrys AGawrys self-requested a review October 18, 2023 00:35
@mattcompiles mattcompiles merged commit 47cf0e1 into v2 Oct 18, 2023
15 of 16 checks passed
@mischnic mischnic deleted the fix-inline-consts-shared-bundles branch October 18, 2023 08:21
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGawrys AGawrys AGawrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcompiles @parcel-benchmark @AGawrys