Add unstable manual shared bundles #9251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mattcompiles
changed the title
marcins
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This is a PR for an unstable
unstable_manualSharedBundlesoption for the Default Bundler. We've found that being able to stipulate unsplittable files via config helped transition bundlers internally, while leveraging previous bundler configs which Parcel could not interpret.With this change, users can specify a "parent" file and a glob of
assets, resulting in a single bundle containing those assets only, and deduplicating where possible. They can also specify anameandtypesof assets to be supported. The example below will create two bundles from "sharedFile.tsx" , one forcssassets and one forjs.Config
stringArray<Glob>?number?string?Array<string>['js', 'css']Usage
{ "@parcel/bundler-default": { "unstable_manualSharedBundles": [ { "name": "mySharedCode", "parent": "src/packages/sharing/sharedfiles.tsx", "types": ["js", "css"], "assets": ["**/*"], "split": 3 } ] } }This PR also includes the ability to have
modespecific config for the bundler. Config inside amodekey will be merged over the general mode properties. Note that onlydevelopmentandproductionare currently supported, custom modes can't have custom config.{ "@parcel/bundler-default": { "development": { "disableSharedBundles": true } } }Notable Changes
manualSharedBundlewhich corresponds to the optionalnamefrom the user-defined config. This helps us name these new manual shared bundles appropriately later with a custom namersplit: number.👂 Questions
✔️ PR Todo